Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1836253002: Making new unit test assertions use the standard timeout. (Closed)

Created:
4 years, 8 months ago by Taylor Brandstetter
Modified:
4 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Making new unit test assertions use the standard timeout. This is to reduce the likelihood of them flaking in the future. R=pthatcher@webrtc.org Committed: https://crrev.com/d45b95c2703614be991e761ac0297210f494f222 Cr-Commit-Position: refs/heads/master@{#12149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M webrtc/api/peerconnectioninterface_unittest.cc View 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
4 years, 8 months ago (2016-03-29 17:55:53 UTC) #2
pthatcher1
lgtm
4 years, 8 months ago (2016-03-29 18:54:01 UTC) #3
Taylor Brandstetter
Committed patchset #1 (id:1) manually as d45b95c2703614be991e761ac0297210f494f222 (presubmit successful).
4 years, 8 months ago (2016-03-29 20:17:00 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 20:17:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d45b95c2703614be991e761ac0297210f494f222
Cr-Commit-Position: refs/heads/master@{#12149}

Powered by Google App Engine
This is Rietveld 408576698