Add RTCConfiguration getter and setter methods.

webrtc/api/peerconnectioninterface.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 205 matching lines @@
     kTcpCandidatePolicyDisabled
   };
 
   enum ContinualGatheringPolicy {
     GATHER_ONCE,
     GATHER_CONTINUALLY
   };
 
   // TODO(hbos): Change into class with private data and public getters.
   struct RTCConfiguration {
+    // We need getter and setter methods for the flags which are used
+    // by applications, chrome in particular.
+
+    // TODO(nisse): Properly named getter methods currently collide
+    // with the attributes they get. Add when attributes are moved
+    // inside MediaConfig.
+    void set_enable_dscp(bool flag) { enable_dscp = rtc::Optional<bool>(flag); }

[perkj_webrtc, 2016/03/31 07:35:21]

set_dscp(bool enable)

+
+    // TODO(nisse): The corresponding flag in MediaConfig and
+    // elsewhere should be renamed enable_cpu_adaptation.
+    bool cpu_adaptation() { return cpu_overuse_detection.value_or(true); }
+    void set_cpu_adaptation(bool enabled) {
+      cpu_overuse_detection = rtc::Optional<bool>(enabled);
+    }
+
+    void set_suspend_below_min_bitrate(bool enabled) {
+      suspend_below_min_bitrate = rtc::Optional<bool>(enabled);
+    }
+
+    // TODO(nisse): This negation in the name (both of this method,
+    // and the corresponding MediaConfig attribute) is inconsistent,
+    // and makes it tempting to add otherwise redundant enable_
+    // prefixes on the other flags. So rename, and for the transition
+    // we can keep this method and let it negate its argument.
+    void set_disable_prerenderer_smoothing(bool disabled) {

[perkj_webrtc, 2016/03/31 07:35:21]

set_prerender_smoo.... (bool enable)

+      disable_prerenderer_smoothing = disabled;
+    }
+
     static const int kUndefined = -1;
     // Default maximum number of packets in the audio jitter buffer.
     static const int kAudioJitterBufferMaxPackets = 50;
     // TODO(pthatcher): Rename this ice_transport_type, but update
     // Chromium at the same time.
     IceTransportsType type;
     // TODO(pthatcher): Rename this ice_servers, but update Chromium
     // at the same time.
     IceServers servers;
     BundlePolicy bundle_policy;
@@ skipping 421 matching lines @@
 CreatePeerConnectionFactory(
     rtc::Thread* worker_thread,
     rtc::Thread* signaling_thread,
     AudioDeviceModule* default_adm,
     cricket::WebRtcVideoEncoderFactory* encoder_factory,
     cricket::WebRtcVideoDecoderFactory* decoder_factory);
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_PEERCONNECTIONINTERFACE_H_