Change default timestamp to 64 bits in all webrtc directories.

webrtc/base/ratetracker.h

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_BASE_RATETRACKER_H_
 #define WEBRTC_BASE_RATETRACKER_H_
 
 #include <stdlib.h>
 #include "webrtc/base/basictypes.h"
 
 namespace rtc {
 
 // Computes units per second over a given interval by tracking the units over
 // each bucket of a given size and calculating the instantaneous rate assuming
 // that over each bucket the rate was constant.
 class RateTracker {
  public:
-  RateTracker(uint32_t bucket_milliseconds, size_t bucket_count);
+  RateTracker(int bucket_milliseconds, size_t bucket_count);
   virtual ~RateTracker();
 
   // Computes the average rate over the most recent interval_milliseconds,
   // or if the first sample was added within this period, computes the rate
   // since the first sample was added.
-  double ComputeRateForInterval(uint32_t interval_milliseconds) const;
+  double ComputeRateForInterval(int interval_milliseconds) const;
 
   // Computes the average rate over the rate tracker's recording interval
   // of bucket_milliseconds * bucket_count.
   double ComputeRate() const {
     return ComputeRateForInterval(bucket_milliseconds_ *
-                                  static_cast<uint32_t>(bucket_count_));
+                                  static_cast<int>(bucket_count_));
   }
 
   // Computes the average rate since the first sample was added to the
   // rate tracker.
   double ComputeTotalRate() const;
 
   // The total number of samples added.
   size_t TotalSampleCount() const;
 
   // Reads the current time in order to determine the appropriate bucket for
   // these samples, and increments the count for that bucket by sample_count.
   void AddSamples(size_t sample_count);
 
  protected:
   // overrideable for tests
-  virtual uint32_t Time() const;
+  virtual int64_t Time() const;
 
  private:
   void EnsureInitialized();
   size_t NextBucketIndex(size_t bucket_index) const;
 
-  const uint32_t bucket_milliseconds_;
+  const int bucket_milliseconds_;

[pthatcher1, 2016/04/11 20:56:59]

Why not uint64_t?

[honghaiz3, 2016/04/18 23:39:04]

As explained in the other comment, I do not use uintXX here following the style
guide. 
It is highly unlikely that a call duration will overflow an integer value (more
than 23 days for a signed int), so I guess int is sufficient. 

[Taylor Brandstetter, 2016/04/19 20:35:27]

I totally agree about using signed values. But I don't think it hurts to use a
64-bit value. I'm sure there are some niche use cases where WebRTC is used for
several days without stopping (there was even a bug recently about a problem
that occurs after 2 weeks).

[honghaiz3, 2016/04/22 23:45:20]

Done.

   const size_t bucket_count_;
   size_t* sample_buckets_;
   size_t total_sample_count_;
   size_t current_bucket_;
-  uint32_t bucket_start_time_milliseconds_;
-  uint32_t initialization_time_milliseconds_;
+  int64_t bucket_start_time_milliseconds_;
+  int64_t initialization_time_milliseconds_;
 };
 
 }  // namespace rtc
 
 #endif  // WEBRTC_BASE_RATETRACKER_H_