Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1832793002: More cleanup of cricket::VideoCapturer Remove unused state CS_PAUSED Remove unused SignalVideoFrame (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
nisse-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

More cleanup of cricket::VideoCapturer Remove unused state CS_PAUSED and dummy implementation of Pause() Remove unused SignalVideoFrame This should now be possible since https://codereview.chromium.org/1745923002/ has landed. BUG=webrtc:5426 Committed: https://crrev.com/4a3a135e68154488289d4aa4a987475912faa7be Cr-Commit-Position: refs/heads/master@{#12116}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -24 lines) Patch
M webrtc/api/videocapturertracksource.cc View 1 chunk +0 lines, -2 lines 2 comments Download
M webrtc/media/base/videocapturer.h View 5 chunks +3 lines, -17 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
perkj_webrtc
please?
4 years, 9 months ago (2016-03-24 09:44:57 UTC) #3
nisse-webrtc
https://codereview.webrtc.org/1832793002/diff/1/webrtc/api/videocapturertracksource.cc File webrtc/api/videocapturertracksource.cc (left): https://codereview.webrtc.org/1832793002/diff/1/webrtc/api/videocapturertracksource.cc#oldcode53 webrtc/api/videocapturertracksource.cc:53: return MediaSourceInterface::kMuted; Is appears to be the last use ...
4 years, 9 months ago (2016-03-24 09:55:01 UTC) #4
perkj_webrtc
https://codereview.webrtc.org/1832793002/diff/1/webrtc/api/videocapturertracksource.cc File webrtc/api/videocapturertracksource.cc (left): https://codereview.webrtc.org/1832793002/diff/1/webrtc/api/videocapturertracksource.cc#oldcode53 webrtc/api/videocapturertracksource.cc:53: return MediaSourceInterface::kMuted; On 2016/03/24 09:55:01, nisse-webrtc wrote: > Is ...
4 years, 9 months ago (2016-03-24 10:05:31 UTC) #5
nisse-webrtc
lgtm
4 years, 9 months ago (2016-03-24 10:08:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1832793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1832793002/1
4 years, 9 months ago (2016-03-24 10:08:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 11:39:54 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 11:40:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a3a135e68154488289d4aa4a987475912faa7be
Cr-Commit-Position: refs/heads/master@{#12116}

Powered by Google App Engine
This is Rietveld 408576698