Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1743)

Unified Diff: webrtc/media/base/videoframe_unittest.h

Issue 1831523004: Move InitToBlack and Reset methods from cricket::VideoFrame to its subclass cricket::WebRtcVideoFra… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videoframe.h ('k') | webrtc/media/engine/webrtcvideoframe.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/base/videoframe_unittest.h
diff --git a/webrtc/media/base/videoframe_unittest.h b/webrtc/media/base/videoframe_unittest.h
index 88119fd672f14e0776f0dbd35d5773dee0fc0e40..18bcc7d5cf771c5368a401c029e3b22980cb9e7f 100644
--- a/webrtc/media/base/videoframe_unittest.h
+++ b/webrtc/media/base/videoframe_unittest.h
@@ -1372,6 +1372,10 @@ class VideoFrameTest : public testing::Test {
}
}
+ // TODO(nisse): Reset is no longer a public method, and not
perkj_webrtc 2016/03/24 09:53:00 Take a look and advice please. You can probably m
nisse-webrtc 2016/03/24 10:03:14 Only problem is that the Init-method to test takes
+ // available here. It is used by the two Init methods. Do we have
+ // adequate tests form WebRtcVideoFrame::Init?
+#if 0
// Tests re-initing an existing image.
void Reset(webrtc::VideoRotation rotation, bool apply_rotation) {
T frame1, frame2;
@@ -1413,6 +1417,7 @@ class VideoFrameTest : public testing::Test {
void ResetAndDontApplyRotation() {
Reset(webrtc::kVideoRotation_90, false);
}
+#endif
//////////////////////
// Conversion tests //
« no previous file with comments | « webrtc/media/base/videoframe.h ('k') | webrtc/media/engine/webrtcvideoframe.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698