Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1831523004: Move InitToBlack and Reset methods from cricket::VideoFrame to its subclass cricket::WebRtcVideoFra… (Closed)

Created:
4 years, 9 months ago by nisse-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move InitToBlack and Reset methods from cricket::VideoFrame to its subclass cricket::WebRtcVideoFrame. BUG=webrtc:5682 R=perkj@webrtc.org Committed: https://crrev.com/03bd4008b61b7ead41528610de75adafa22d3faf Cr-Commit-Position: refs/heads/master@{#12260}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete Reset test. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -76 lines) Patch
M webrtc/media/base/videoframe.h View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/media/base/videoframe_unittest.h View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe.h View 1 2 2 chunks +16 lines, -13 lines 0 comments Download
M webrtc/media/engine/webrtcvideoframe_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
nisse-webrtc
Eliminates two public methods of cricket::VideoFrame. About the tests, not sure if there are other ...
4 years, 9 months ago (2016-03-24 09:42:22 UTC) #2
perkj_webrtc
Change looks good but what is the purpose of moving them if the end goal ...
4 years, 9 months ago (2016-03-24 09:53:00 UTC) #3
nisse-webrtc
I like to cut down on the size of the cricket::VideoFrame interface, to get it ...
4 years, 9 months ago (2016-03-24 10:03:14 UTC) #4
perkj_webrtc
On 2016/03/24 10:03:14, nisse-webrtc wrote: > I like to cut down on the size of ...
4 years, 9 months ago (2016-03-24 10:26:19 UTC) #5
nisse-webrtc
On 2016/03/24 10:26:19, perkj_webrtc wrote: > On 2016/03/24 10:03:14, nisse-webrtc wrote: > > I like ...
4 years, 9 months ago (2016-03-24 13:18:31 UTC) #6
nisse-webrtc
I've investigated the testing. Broken apply_rotation handling in the Reset method triggers other unit tests, ...
4 years, 8 months ago (2016-03-30 11:33:44 UTC) #7
perkj_webrtc
lgtm
4 years, 8 months ago (2016-03-31 05:01:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831523004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831523004/40001
4 years, 8 months ago (2016-04-06 09:04:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-04-06 11:05:12 UTC) #13
nisse-webrtc
Committed patchset #3 (id:40001) manually as 03bd4008b61b7ead41528610de75adafa22d3faf (presubmit successful).
4 years, 8 months ago (2016-04-06 11:07:26 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 11:07:27 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03bd4008b61b7ead41528610de75adafa22d3faf
Cr-Commit-Position: refs/heads/master@{#12260}

Powered by Google App Engine
This is Rietveld 408576698