Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1830713003: Remove unused stuff from AudioFrame: (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused stuff from AudioFrame: - The interleaved_ field. Never set to anything but 'true'. AudioFrame data appears to always be treated as interleaved. - The Append() method. - operator-=(). BUG= Committed: https://crrev.com/0d343fa39dfdc9a35cae6e792474893890a242f8 Cr-Commit-Position: refs/heads/master@{#12152}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M webrtc/modules/audio_coding/neteq/sync_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/include/module_common_types.h View 1 7 chunks +0 lines, -55 lines 0 comments Download
M webrtc/modules/utility/source/audio_frame_operations.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
the sun
4 years, 9 months ago (2016-03-24 14:02:40 UTC) #2
tlegrand-webrtc
On 2016/03/24 14:02:40, the sun wrote: LGTM I'm surprised we never checked if the data ...
4 years, 8 months ago (2016-03-29 14:34:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830713003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830713003/20001
4 years, 8 months ago (2016-03-29 21:56:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 23:42:14 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 23:42:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d343fa39dfdc9a35cae6e792474893890a242f8
Cr-Commit-Position: refs/heads/master@{#12152}

Powered by Google App Engine
This is Rietveld 408576698