Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: webrtc/api/java/android/org/webrtc/EglBase14.java

Issue 1829923002: Switch to using EGL 1.0 for rendering and HW codec. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/java/android/org/webrtc/EglBase14.java
diff --git a/webrtc/api/java/android/org/webrtc/EglBase14.java b/webrtc/api/java/android/org/webrtc/EglBase14.java
index f23ca949e468a02927bbc717b6f21bd82e7334af..5b377e0bad1a073800f7f2c9dc25d304004868a9 100644
--- a/webrtc/api/java/android/org/webrtc/EglBase14.java
+++ b/webrtc/api/java/android/org/webrtc/EglBase14.java
@@ -38,10 +38,13 @@ public final class EglBase14 extends EglBase {
// EGL 1.4 is supported from API 17. But EGLExt that is used for setting presentation
// time stamp on a surface is supported from 18 so we require 18.
+ // Currently EGL 1.4 support is disabled for all devices, since it causes deadlock
+ // in Android view rendering on some devices.
+ // TODO(magjed,glaznev) - investigate if it can be re-enabled back.
public static boolean isEGL14Supported() {
- Logging.d(TAG, "SDK version: " + CURRENT_SDK_VERSION
- + ". isEGL14Supported: " + (CURRENT_SDK_VERSION >= EGLExt_SDK_VERSION));
- return (CURRENT_SDK_VERSION >= EGLExt_SDK_VERSION);
+ Logging.d(TAG, "SDK version: " + CURRENT_SDK_VERSION +
+ ". isEGL14Supported: forced to false.");
+ return false;
}
public static class Context extends EglBase.Context {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698