Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1829323002: Revert of Added a bitexactness test for the gain controller in the audio processing module. (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@AecmBitExactness_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added a bitexactness test for the gain controller in the audio processing module. (patchset #3 id:60001 of https://codereview.webrtc.org/1812433002/ ) Reason for revert: This CL are breaking some of the Android buildbots in Chromium. The CL will need be be revised to exclude the Android platform. Original issue's description: > Added a bitexactness test for the gain controller in the audio processing module. > > BUG=webrtc:5339 > > Committed: https://crrev.com/a49dc36976da44f3d6d75aed2dcab93fe14fc3a0 > Cr-Commit-Position: refs/heads/master@{#12124} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5339 Committed: https://crrev.com/918d0157371899152d4d3578aa0fb778d8a1f13f Cr-Commit-Position: refs/heads/master@{#12127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -316 lines) Patch
D webrtc/modules/audio_processing/gain_control_unittest.cc View 1 chunk +0 lines, -315 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
peah-webrtc
Created Revert of Added a bitexactness test for the gain controller in the audio processing ...
4 years, 9 months ago (2016-03-25 07:50:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829323002/1
4 years, 9 months ago (2016-03-25 07:50:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 07:50:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/918d0157371899152d4d3578aa0fb778d8a1f13f Cr-Commit-Position: refs/heads/master@{#12127}
4 years, 9 months ago (2016-03-25 07:50:54 UTC) #6
hlundin-webrtc
4 years, 8 months ago (2016-03-29 21:05:05 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698