Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1829193002:
Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. (Closed)
|
Created:
4 years, 9 months ago by peah-webrtc Modified:
4 years, 8 months ago Reviewers:
hlundin-webrtc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRe-reland of Added a bitexactness test for the echo canceller in the audio processing module.
This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots.
The reverting CL was https://codereview.webrtc.org/1827863003/
This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms
TBR=henrik.lundin@webrtc.org
BUG=webrtc:5337
Committed: https://crrev.com/d4f6ea70b532d0369a0f11ffbf08335a6ff30d8b
Cr-Commit-Position: refs/heads/master@{#12131}
Patch Set 1 #Patch Set 2 : Corrected the boolean expression for the conditional on platform testing #Patch Set 3 : Deactivated the test for Android and reduced the number of interations #
Total comments: 2
Patch Set 4 : Rebase #Messages
Total messages: 24 (12 generated)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829193002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/13817)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829193002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_x64_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_gn_rel/builds/8027)
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829193002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, Since I've needed to do some reverts of the bitexactness code I've deactivated the gain controller and aec bitexactness tests for the Android and ARM platforms. I've also reduced the number of iterations to reduce the impact of of numerical floating point issues. The problem is that the test fails on the Chromium bots and not on the WebRTC bots, so the CL needs to be reverted if that happens.
Description was changed from ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ========== to ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all ARM and ARM64 platforms BUG=webrtc:5337 ==========
Description was changed from ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all ARM and ARM64 platforms BUG=webrtc:5337 ========== to ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ==========
Description was changed from ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ========== to ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ==========
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829193002/60001
Message was sent while issue was closed.
Description was changed from ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ========== to ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 ========== to ========== Re-reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1827833006/ that was reverted due to problems of the bitexactness of the Chromium Android64 and Android32 bots. The reverting CL was https://codereview.webrtc.org/1827863003/ This new action taken in this CL is to disable the test for all Android, ARM and ARM64 platforms TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 Committed: https://crrev.com/d4f6ea70b532d0369a0f11ffbf08335a6ff30d8b Cr-Commit-Position: refs/heads/master@{#12131} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d4f6ea70b532d0369a0f11ffbf08335a6ff30d8b Cr-Commit-Position: refs/heads/master@{#12131}
Message was sent while issue was closed.
LGTM with comment after the fact. https://codereview.webrtc.org/1829193002/diff/40001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/echo_cancellation_unittest.cc (right): https://codereview.webrtc.org/1829193002/diff/40001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/echo_cancellation_unittest.cc:20: defined(WEBRTC_ANDROID)) Again, I prefer disabling the test rather than excluding the code.
Message was sent while issue was closed.
https://codereview.webrtc.org/1829193002/diff/40001/webrtc/modules/audio_proc... File webrtc/modules/audio_processing/echo_cancellation_unittest.cc (right): https://codereview.webrtc.org/1829193002/diff/40001/webrtc/modules/audio_proc... webrtc/modules/audio_processing/echo_cancellation_unittest.cc:20: defined(WEBRTC_ANDROID)) On 2016/03/29 21:23:56, hlundin-webrtc wrote: > Again, I prefer disabling the test rather than excluding the code. Good point! I will create a CL to change that. |
