Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1828773003: Revert of Remove code interfacing legacy openssl. (Closed)

Created:
4 years, 9 months ago by torbjorng (webrtc)
Modified:
4 years, 9 months ago
Reviewers:
tommi, davidben_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove code interfacing legacy openssl. (patchset #3 id:40001 of https://codereview.webrtc.org/1808763002/ ) Reason for revert: We will make it possible to link to BoringSSL for WebRTC's usages of the crypto APIs and OpenSSL for other usages in the same binary. Once that is completed, we will reland this. Original issue's description: > Remove code interfacing legacy openssl. > > BUG=webrtc:5664 > > Committed: https://crrev.com/4cd331beade6de16c073dcdaf89c4e038bdbf73f > Cr-Commit-Position: refs/heads/master@{#12041} TBR=tommi@webrtc.org,davidben@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5664 Committed: https://crrev.com/9adc91d9cc254e78507663fdd194dbdde84b9274 Cr-Commit-Position: refs/heads/master@{#12117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -3 lines) Patch
M webrtc/base/openssl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/openssladapter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/base/openssladapter.cc View 2 chunks +120 lines, -1 line 0 comments Download
M webrtc/base/opensslidentity.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 13 chunks +189 lines, -0 lines 0 comments Download
M webrtc/base/ssladapter.cc View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
torbjorng (webrtc)
Created Revert of Remove code interfacing legacy openssl.
4 years, 9 months ago (2016-03-24 11:33:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828773003/1
4 years, 9 months ago (2016-03-24 11:33:34 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4396)
4 years, 9 months ago (2016-03-24 11:38:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828773003/1
4 years, 9 months ago (2016-03-24 12:47:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4402)
4 years, 9 months ago (2016-03-24 13:00:03 UTC) #8
torbjorng (webrtc)
Committed patchset #1 (id:1) manually as 9adc91d9cc254e78507663fdd194dbdde84b9274 (presubmit successful).
4 years, 9 months ago (2016-03-24 13:05:26 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:05:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9adc91d9cc254e78507663fdd194dbdde84b9274
Cr-Commit-Position: refs/heads/master@{#12117}

Powered by Google App Engine
This is Rietveld 408576698