Issue 1828463002: Adding comments about threading around CreatePeerConnectionFactory.

Issue 1828463002: Adding comments about threading around CreatePeerConnectionFactory. (Closed)

Created:
4 years, 9 months ago by Taylor Brandstetter

Modified:
4 years, 9 months ago

Reviewers:
pthatcher1

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@master

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

Adding comments about threading around CreatePeerConnectionFactory. This has confused a lot of developers (understandably). R=pthatcher@webrtc.org Committed: https://crrev.com/a8415fe9ea381946148498f1fe7fd0b2b04f02ec Cr-Commit-Position: refs/heads/master@{#12105}

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -13 lines)			Patch
	M	webrtc/api/peerconnectionfactory.cc	View		2 chunks	+6 lines, -11 lines	0 comments	Download
	M	webrtc/api/peerconnectioninterface.h	View		1 chunk	+15 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

Taylor Brandstetter

Committed patchset #1 (id:1) manually as a8415fe9ea381946148498f1fe7fd0b2b04f02ec (presubmit successful).

4 years, 9 months ago (2016-03-23 17:38:21 UTC) #5

commit-bot: I haz the power

4 years, 9 months ago (2016-03-23 17:38:25 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a8415fe9ea381946148498f1fe7fd0b2b04f02ec
Cr-Commit-Position: refs/heads/master@{#12105}