webrtc/base/opensslidentity.cc - Issue 1828433003: Move to x509 v3 as required by the WebRTC draft.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/base/opensslidentity.cc

Issue 1828433003: Move to x509 v3 as required by the WebRTC draft. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/base/opensslidentity.cc

diff --git a/webrtc/base/opensslidentity.cc b/webrtc/base/opensslidentity.cc

index 269bfced1706f612a8f82ab566eea28ce4b4bb53..8933fb6aaf5883c2a128d464b2b57325e07f5b88 100644

--- a/webrtc/base/opensslidentity.cc

+++ b/webrtc/base/opensslidentity.cc

@@ -107,7 +107,7 @@ static X509* MakeCertificate(EVP_PKEY* pkey, const SSLIdentityParams& params) {

!BN_to_ASN1_INTEGER(serial_number, asn1_serial_number))

goto error;

- if (!X509_set_version(x509, 0L)) // version 1

+ if (!X509_set_version(x509, 2L)) // version 3

goto error;

// There are a lot of possible components for the name entries. In

« no previous file with comments | « no previous file | no next file » | no next file with comments »