Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 1828233002: ReAdd dummy MediaStreamTrack::set_state to make Chrome build happy. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
Reviewers:
guidou
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

ReAdd dummy MediaStreamTrack::set_state to make Chrome build happy. https://codereview.webrtc.org/1816143002/ broke the Chrome test builds. The method is only used for tests and adding a dummy implementation seem to be enough. BUG=webrtc:5426 R=guidou@webrtc.org Committed: https://crrev.com/7ca142e04723196c27cf32a4a558b67119e2e5ef Cr-Commit-Position: refs/heads/master@{#12118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828233002/1
4 years, 9 months ago (2016-03-24 13:13:25 UTC) #2
perkj_webrtc
Please?
4 years, 9 months ago (2016-03-24 13:13:39 UTC) #4
perkj_webrtc
...
4 years, 9 months ago (2016-03-24 13:15:36 UTC) #6
guidou
lgtm
4 years, 9 months ago (2016-03-24 13:15:54 UTC) #7
perkj_webrtc
Committed patchset #1 (id:1) manually as 7ca142e04723196c27cf32a4a558b67119e2e5ef (presubmit successful).
4 years, 9 months ago (2016-03-24 13:19:31 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:19:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ca142e04723196c27cf32a4a558b67119e2e5ef
Cr-Commit-Position: refs/heads/master@{#12118}

Powered by Google App Engine
This is Rietveld 408576698