Android HW encoder: Add support for textures when using EGL 1.0

Android HW encoder: Add support for textures when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that CL, the EGL context passed to PeerConnectionFactory nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4 context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the encoder, which means that the encoder won't encode from the texture directly, but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call to eglPresentationTimeANDROID.

BUG=webrtc:5702

[magjed_webrtc, 2016-03-24 11:10:21]

Description was changed from

==========
Android MediaCodecVideoEncoder: Handle passing EGL 1.0 contexts in initEncode
==========

to

==========
Android MediaCodecVideoEncoder: Handle passing EGL 1.0 contexts in initEncode

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed in initEncode is an EGL 1.0 context, not an EGL 1.4
context. The context is casted from EglBase10.Context to EglBase14.Context here:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

This CL changes the parameter type in initEncode from EglBase14.Context to
EglBase.Context and use instanceof when swapping buffers to check if it's
possible to call eglPresentationTimeANDROID or not.
==========

[magjed_webrtc, 2016-03-24 11:11:50]

magjed@webrtc.org changed reviewers:
+ glaznev@webrtc.org, perkj@webrtc.org

[magjed_webrtc, 2016-03-29 09:38:05]

Description was changed from

==========
Android MediaCodecVideoEncoder: Handle passing EGL 1.0 contexts in initEncode

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed in initEncode is an EGL 1.0 context, not an EGL 1.4
context. The context is casted from EglBase10.Context to EglBase14.Context here:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...

This CL changes the parameter type in initEncode from EglBase14.Context to
EglBase.Context and use instanceof when swapping buffers to check if it's
possible to call eglPresentationTimeANDROID or not.
==========

to

==========
Android MediaCodecVideoEncoder: Handle passing EGL 1.0 contexts in initEncode

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder and decoder, which means that the decoder won't output texture frames
anymore, and that the encoder won't encode from the texture directly, but will
call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL:
 * Makes the decoder output texture frames for EGL 1.0 as well.
 * Encodes directly from textures for EGL 1.0 as well, but ignores the call to
eglPresentationTimeANDROID.
==========

[magjed_webrtc, 2016-03-29 09:43:18]

Description was changed from

==========
Android MediaCodecVideoEncoder: Handle passing EGL 1.0 contexts in initEncode

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder and decoder, which means that the decoder won't output texture frames
anymore, and that the encoder won't encode from the texture directly, but will
call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL:
 * Makes the decoder output texture frames for EGL 1.0 as well.
 * Encodes directly from textures for EGL 1.0 as well, but ignores the call to
eglPresentationTimeANDROID.
==========

to

==========
Android: Add support for textures in encoder/decoder when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder and decoder, which means that the decoder won't output texture frames
anymore, and that the encoder won't encode from the texture directly, but will
call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL:
 * Makes the decoder output texture frames for EGL 1.0 as well.
 * Encodes directly from textures for EGL 1.0 as well, but ignores the call to
eglPresentationTimeANDROID.
==========

[magjed_webrtc, 2016-03-29 10:42:49]

Patchset #3 (id:40001) has been deleted

[magjed_webrtc, 2016-03-29 10:43:38]

Description was changed from

==========
Android: Add support for textures in encoder/decoder when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder and decoder, which means that the decoder won't output texture frames
anymore, and that the encoder won't encode from the texture directly, but will
call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL:
 * Makes the decoder output texture frames for EGL 1.0 as well.
 * Encodes directly from textures for EGL 1.0 as well, but ignores the call to
eglPresentationTimeANDROID.
==========

to

==========
Android: Add support for textures in encoder/decoder when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder, which means that the encoder won't encode from the texture directly,
but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call
to eglPresentationTimeANDROID.
==========

[magjed_webrtc, 2016-03-29 10:46:05]

Description was changed from

==========
Android: Add support for textures in encoder/decoder when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder, which means that the encoder won't encode from the texture directly,
but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call
to eglPresentationTimeANDROID.
==========

to

==========
Android HW encoder: Add support for textures when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder, which means that the encoder won't encode from the texture directly,
but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call
to eglPresentationTimeANDROID.
==========

[perkj_webrtc, 2016-03-29 11:10:16]

cl looks good. Please add a a reference to a bug.

https://codereview.webrtc.org/1828203002/diff/60001/webrtc/api/java/src/org/w...
File webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1828203002/diff/60001/webrtc/api/java/src/org/w...
webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java:400: ((EglBase14)
eglBase).swapBuffers(TimeUnit.MICROSECONDS.toNanos(presentationTimestampUs));
Please add a reference to a bug why this is not always Egl14 and a comment why
we do this. Also what we are afraid might happen when we do this. (from email
conversation).

[magjed_webrtc, 2016-03-29 11:20:20]

Description was changed from

==========
Android HW encoder: Add support for textures when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder, which means that the encoder won't encode from the texture directly,
but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call
to eglPresentationTimeANDROID.
==========

to

==========
Android HW encoder: Add support for textures when using EGL 1.0

This CL is a follow-up to https://codereview.webrtc.org/1829923002. After that
CL, the EGL context passed to PeerConnectionFactory
nativeSetVideoHwAccelerationOptions is an EGL 1.0 context, not an EGL 1.4
context. If it's not an EGL 1.4 context, we don't call SetEGLContext on the
encoder, which means that the encoder won't encode from the texture directly,
but will call ConvertNativeToI420Frame instead and encode from byte buffers.

This CL encodes directly from textures for EGL 1.0 as well, but ignores the call
to eglPresentationTimeANDROID.

BUG=webrtc:5702
==========

[magjed_webrtc, 2016-03-29 11:21:11]

Patchset #2 (id:20001) has been deleted

[magjed_webrtc, 2016-03-29 11:21:19]

Patchset #1 (id:1) has been deleted

[magjed_webrtc, 2016-03-29 11:37:37]

Filed a bug to track this.

https://codereview.webrtc.org/1828203002/diff/60001/webrtc/api/java/src/org/w...
File webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1828203002/diff/60001/webrtc/api/java/src/org/w...
webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java:400: ((EglBase14)
eglBase).swapBuffers(TimeUnit.MICROSECONDS.toNanos(presentationTimestampUs));
On 2016/03/29 11:10:15, perkj_webrtc wrote:
> Please add a reference to a bug why this is not always Egl14 and a comment why
> we do this. Also what we are afraid might happen when we do this. (from email
> conversation). 

Done.

[perkj_webrtc, 2016-03-29 15:15:13]

lgtm with a nit

https://codereview.webrtc.org/1828203002/diff/80001/webrtc/api/java/src/org/w...
File webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1828203002/diff/80001/webrtc/api/java/src/org/w...
webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java:402: // |eglBase| is
not always an instance of EglBase14 because of bug 5702. Setting the
nit: Make sure this is a valid link please.

[AlexG, 2016-03-30 17:10:31]

lgtm

[magjed_webrtc, 2016-03-31 11:28:42]

I think we should revert https://codereview.webrtc.org/1829923002, so I don't
know if I should land this or not.

https://codereview.webrtc.org/1828203002/diff/80001/webrtc/api/java/src/org/w...
File webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java (right):

https://codereview.webrtc.org/1828203002/diff/80001/webrtc/api/java/src/org/w...
webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java:402: // |eglBase| is
not always an instance of EglBase14 because of bug 5702. Setting the
On 2016/03/29 15:15:13, perkj_webrtc wrote:
> nit: Make sure this is a valid link please.

Done.