Make rtcp sender use max transfer unit.

Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson

Committed: https://crrev.com/41befcee7d25dabb8f6871dcdef4adc1a0004932
Cr-Commit-Position: refs/heads/master@{#12165}

[danilchap, 2016-03-24 10:26:14]

RtpSender has no use for packet overhead, while RtcpSender does.
RtcpSender should also use max transfer unit instead of creating packets without
reserving space for tcp/udp or authentication headers.

[åsapersson, 2016-03-30 10:28:36]

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:610:
candidateSet->SetEntry(lengthOfBoundingSet, tmmbr_send_, packet_overhead_,
Should packet_overhead_ for tmmbr include the RTP header length (i.e. be 40
bytes by default)?

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:245: size_t max_payload_length_;
guarded by?

[danilchap, 2016-03-30 12:18:19]

Description was changed from

==========
Make rtcp sender use max transfer unit.
Make rtcp sender use packet overhead default of 28 instead of 0 for tmmbr
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson
==========

to

==========
Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson
==========

[danilchap, 2016-03-30 12:38:25]

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:610:
candidateSet->SetEntry(lengthOfBoundingSet, tmmbr_send_, packet_overhead_,
On 2016/03/30 10:28:36, åsapersson wrote:
> Should packet_overhead_ for tmmbr include the RTP header length (i.e. be 40
> bytes by default)?

Yes, in fact it should, as well as rtp header extensions.
Which make it more complicated and subject of a different dedicated CL.

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/1827953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:245: size_t max_payload_length_;
On 2016/03/30 10:28:36, åsapersson wrote:
> guarded by?

Not guarded: value is primitive, set independently of other members.   When
used, used once in a function. Guarding it with a mutex doesn't look necessary.

[åsapersson, 2016-03-30 13:31:10]

lgtm

https://codereview.webrtc.org/1827953002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1827953002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:283: void
RTCPSender::SetMaxPayloadLength(size_t length) {
length->max_payload_length

[danilchap, 2016-03-30 14:04:44]

https://codereview.webrtc.org/1827953002/diff/20001/webrtc/modules/rtp_rtcp/s...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1827953002/diff/20001/webrtc/modules/rtp_rtcp/s...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:283: void
RTCPSender::SetMaxPayloadLength(size_t length) {
On 2016/03/30 13:31:10, åsapersson wrote:
> length->max_payload_length

Done.

[danilchap, 2016-03-30 17:34:24]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-03-30 17:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1827953002/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2016-03-30 17:34:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827953002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827953002/40001

[commit-bot: I haz the power, 2016-03-30 18:11:55]

Description was changed from

==========
Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson
==========

to

==========
Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson
==========

[commit-bot: I haz the power, 2016-03-30 18:11:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-30 18:12:00]

Description was changed from

==========
Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson
==========

to

==========
Make rtcp sender use max transfer unit.
Remove packet overhead from rtp sender as unused.

R=philipel, åsapersson

Committed: https://crrev.com/41befcee7d25dabb8f6871dcdef4adc1a0004932
Cr-Commit-Position: refs/heads/master@{#12165}
==========

[commit-bot: I haz the power, 2016-03-30 18:12:01]

Patchset 3 (id:??) landed as
https://crrev.com/41befcee7d25dabb8f6871dcdef4adc1a0004932
Cr-Commit-Position: refs/heads/master@{#12165}