Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 1827863003: Revert of Added a bitexactness test for the echo canceller in the audio processing module. (Closed)

Created:
4 years, 9 months ago by guidou
Modified:
4 years, 9 months ago
Reviewers:
peah-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added a bitexactness test for the echo canceller in the audio processing module. (patchset #2 id:40001 of https://codereview.webrtc.org/1827833006/ ) Reason for revert: This CL is breaking some WebRTC Android bots. Example: https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%20Nexus5%29/builds/6038 Original issue's description: > Reland of Added a bitexactness test for the echo canceller in the audio processing module. > > This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots. > > The reverting CL was https://codereview.webrtc.org/1824583003/ > > TBR=henrik.lundin@webrtc.org > BUG=webrtc:5337 > > Committed: https://crrev.com/e29f0e2515934d5286950da7fc58b548132469ff > Cr-Commit-Position: refs/heads/master@{#12114} TBR=peah@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5337 Committed: https://crrev.com/027fd8f9076da6ae35944956d54050041fd93b4b Cr-Commit-Position: refs/heads/master@{#12119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -327 lines) Patch
D webrtc/modules/audio_processing/echo_cancellation_unittest.cc View 1 chunk +0 lines, -326 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
guidou
Created Revert of Added a bitexactness test for the echo canceller in the audio processing ...
4 years, 9 months ago (2016-03-24 13:43:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827863003/1
4 years, 9 months ago (2016-03-24 13:43:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 13:44:06 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 13:44:14 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/027fd8f9076da6ae35944956d54050041fd93b4b
Cr-Commit-Position: refs/heads/master@{#12119}

Powered by Google App Engine
This is Rietveld 408576698