Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1827833006: Reland of Added a bitexactness test for the echo canceller in the audio processing module. (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 9 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Added a bitexactness test for the echo canceller in the audio processing module. This is a reland of the CL https://codereview.webrtc.org/1809613002/ that was reverted due to problems of the bitexactness of the Chromium Android64 bots. The reverting CL was https://codereview.webrtc.org/1824583003/ TBR=henrik.lundin@webrtc.org BUG=webrtc:5337 Committed: https://crrev.com/e29f0e2515934d5286950da7fc58b548132469ff Cr-Commit-Position: refs/heads/master@{#12114}

Patch Set 1 #

Patch Set 2 : Deactivated the tests on ARM64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -0 lines) Patch
A webrtc/modules/audio_processing/echo_cancellation_unittest.cc View 1 1 chunk +326 lines, -0 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827833006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827833006/20001
4 years, 9 months ago (2016-03-24 07:49:32 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/8543)
4 years, 9 months ago (2016-03-24 07:53:42 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827833006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827833006/40001
4 years, 9 months ago (2016-03-24 08:22:34 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 09:26:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827833006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827833006/40001
4 years, 9 months ago (2016-03-24 09:27:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-24 09:45:58 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e29f0e2515934d5286950da7fc58b548132469ff Cr-Commit-Position: refs/heads/master@{#12114}
4 years, 9 months ago (2016-03-24 09:46:09 UTC) #16
guidou
4 years, 9 months ago (2016-03-24 13:43:42 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/1827863003/ by guidou@webrtc.org.

The reason for reverting is: This CL is breaking some WebRTC Android bots.
Example:
https://build.chromium.org/p/client.webrtc/builders/Android32%20Tests%20%28L%....

Powered by Google App Engine
This is Rietveld 408576698