Shorten single-stream VP8 HW implementation names.

Shorten single-stream VP8 HW implementation names.

Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/d53c3895503d626aacdfbfd8c39f48d3a3c331e9
Cr-Commit-Position: refs/heads/master@{#12161}

[pbos-webrtc, 2016-03-22 19:43:02]

PTAL, this makes AppRTCDemo's stats UI less crowded,
"SimulcastEncoderAdapter(MediaCodec)" is quite wide.

[pbos-webrtc, 2016-03-22 19:43:14]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-22 19:43:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827553002/1

[commit-bot: I haz the power, 2016-03-22 21:13:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 21:13:57]

Dry run: This issue passed the CQ dry run.

[stefan-webrtc, 2016-03-30 13:07:08]

LG

https://codereview.webrtc.org/1827553002/diff/1/webrtc/modules/video_coding/c...
File
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
(right):

https://codereview.webrtc.org/1827553002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:179:
encoders_.erase(std::remove(encoders_.begin(), encoders_.end(), encoder));
This looks weird to me. Why would you want to remove and then erase?

[pbos-webrtc, 2016-03-30 13:50:30]

remove std::remove part

[pbos-webrtc, 2016-03-30 13:51:29]

https://codereview.webrtc.org/1827553002/diff/1/webrtc/modules/video_coding/c...
File
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc
(right):

https://codereview.webrtc.org/1827553002/diff/1/webrtc/modules/video_coding/c...
webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc:179:
encoders_.erase(std::remove(encoders_.begin(), encoders_.end(), encoder));
On 2016/03/30 13:07:08, stefan-webrtc (holmer) wrote:
> This looks weird to me. Why would you want to remove and then erase?

Removed the std::remove part and wrote it myself, std::remove doesn't actually
change the container size and vector doesn't have a good remove method.

[stefan-webrtc, 2016-03-30 13:57:09]

lgtm

[commit-bot: I haz the power, 2016-03-30 15:04:08]

Description was changed from

==========
Shorten single-stream VP8 HW implementation names.

Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org
==========

to

==========
Shorten single-stream VP8 HW implementation names.

Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/d53c3895503d626aacdfbfd8c39f48d3a3c331e9
Cr-Commit-Position: refs/heads/master@{#12161}
==========

[pbos-webrtc, 2016-03-30 15:04:09]

Description was changed from

==========
Shorten single-stream VP8 HW implementation names.

Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org

Committed: https://crrev.com/d53c3895503d626aacdfbfd8c39f48d3a3c331e9
Cr-Commit-Position: refs/heads/master@{#12161}
==========

to

==========
Shorten single-stream VP8 HW implementation names.

Removes "SimulcastEncoderAdapter" from single-stream HW VP8 even though
they are wrapped in a SimulcastEncoderAdapter.

BUG=
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d53c3895503d626aacdfbfd8c...
==========

[commit-bot: I haz the power, 2016-03-30 15:04:09]

Patchset 2 (id:??) landed as
https://crrev.com/d53c3895503d626aacdfbfd8c39f48d3a3c331e9
Cr-Commit-Position: refs/heads/master@{#12161}

[pbos-webrtc, 2016-03-30 15:04:10]

Committed patchset #2 (id:20001) manually as
d53c3895503d626aacdfbfd8c39f48d3a3c331e9 (presubmit successful).