webrtc/media/engine/webrtcvoiceengine.h - Issue 1827263002: Early initialize recording on the ADM from WebRtcVoiceMediaChannel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 1827263002: Early initialize recording on the ADM from WebRtcVoiceMediaChannel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvoiceengine.h

diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h

index 396e3bbb8c0139f6e397dbb95613924b8093740f..eebbdf13c73e93bf88b9bf90e5ec359803f79e9e 100644

--- a/webrtc/media/engine/webrtcvoiceengine.h

+++ b/webrtc/media/engine/webrtcvoiceengine.h

@@ -103,6 +103,7 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback {

void StartAecDump(const std::string& filename);

int CreateVoEChannel();

+ webrtc::AudioDeviceModule* adm();

rtc::ThreadChecker signal_thread_checker_;

rtc::ThreadChecker worker_thread_checker_;

@@ -227,6 +228,7 @@ class WebRtcVoiceMediaChannel final : public VoiceMediaChannel,

bool HasSendCodec() const {

return send_codec_spec_.codec_inst.pltype != -1;

}

+ void SetupRecording();

rtc::ThreadChecker worker_thread_checker_;

« no previous file with comments | « webrtc/audio/audio_send_stream.cc ('k') | webrtc/media/engine/webrtcvoiceengine.cc » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')