webrtc/audio/audio_send_stream.cc - Issue 1827263002: Early initialize recording on the ADM from WebRtcVoiceMediaChannel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/audio/audio_send_stream.cc

Issue 1827263002: Early initialize recording on the ADM from WebRtcVoiceMediaChannel. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: addressed comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/audio/audio_send_stream.cc

diff --git a/webrtc/audio/audio_send_stream.cc b/webrtc/audio/audio_send_stream.cc

index 24afcbcf58e94ad2582dd9fc88cf7860f27d3b2d..1d85a072f52212b17dc1635227885253bc9bd9e9 100644

--- a/webrtc/audio/audio_send_stream.cc

+++ b/webrtc/audio/audio_send_stream.cc

@@ -97,11 +97,7 @@ AudioSendStream::~AudioSendStream() {

void AudioSendStream::Start() {

RTC_DCHECK(thread_checker_.CalledOnValidThread());

- ScopedVoEInterface<VoEBase> base(voice_engine());

- int error = base->StartSend(config_.voe_channel_id);

- if (error != 0) {

- LOG(LS_ERROR) << "AudioSendStream::Start failed with error: " << error;

- }

+ channel_proxy_->StartSend();

}

void AudioSendStream::Stop() {

« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvoiceengine.h » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')