Early initialize recording on the ADM from WebRtcVoiceMediaChannel.

webrtc/voice_engine/channel_proxy.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 140 matching lines @@
 bool ChannelProxy::SendTelephoneEventOutband(int event, int duration_ms) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   return channel()->SendTelephoneEventOutband(event, duration_ms) == 0;
 }
 
 void ChannelProxy::SetSink(std::unique_ptr<AudioSinkInterface> sink) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   channel()->SetSink(std::move(sink));
 }
 
+void ChannelProxy::StartSend() {
+  RTC_DCHECK(thread_checker_.CalledOnValidThread());
+  int32_t error = channel()->StartSend();
+  RTC_DCHECK_EQ(0, error);

[Taylor Brandstetter, 2016/03/29 01:05:38]

Is there a reason to switch from logging an error to using RTC_DCHECK_EQ?

[the sun, 2016/03/31 10:49:47]

Yes, there is a reason. AFAICT StartSend() can never fail, so this isn't
something we need to log. Rather, it is a programming logic error, i.e. either I
read the code wrong just now, or someone changes the code in the below layers so
the assumption doesn't hold anymore. In both cases a logic error, therefore an
assertion is appropriate.

[Taylor Brandstetter, 2016/03/31 18:11:26]

If it should never fail, it seems like it would make sense to remove the return
code in order to make that requirement explicit. But that's a separate matter
from this CL, so this is good for now.

[the sun, 2016/04/01 09:07:46]

voe::Channel is still accessed via the legacy VoE interfaces (VoEBase, etc),
which are being deprecated. I don't see much point in changing code in them.
Instead, I've introduced the interim ChannelProxy class which provides a
cleaned-up "view" of voe::Channel to the new AudioReceive/SendStream classes, as
well as allowing to mock voe::Channel functionality so the stream classes can be
tested. Once the legacy APIs are removed, voe::Channel can more easily be
changed, and its functionality assimilated by the stream classes.

+}
+
 Channel* ChannelProxy::channel() const {
   RTC_DCHECK(channel_owner_.channel());
   return channel_owner_.channel();
 }
 
 }  // namespace voe
 }  // namespace webrtc