Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: webrtc/api/rtpsender.cc

Issue 1827023002: Get VideoCapturer stats via VideoTrackSourceInterface in StatsCollector, (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Move StatsReport logic to VideoRtpSender. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/rtpsender.cc
diff --git a/webrtc/api/rtpsender.cc b/webrtc/api/rtpsender.cc
index a7537867e26f2bb4104e64f4350d52eb7b6bca3f..f8ba8b09d13f3cece6f0e73828aa0bc65fbe3c92 100644
--- a/webrtc/api/rtpsender.cc
+++ b/webrtc/api/rtpsender.cc
@@ -346,4 +346,22 @@ bool VideoRtpSender::SetParameters(const RtpParameters& parameters) {
return provider_->SetVideoRtpParameters(ssrc_, parameters);
}
+StatsReport::Id VideoRtpSender::stats_id() {
+ return StatsReport::NewIdWithDirection(StatsReport::kStatsReportTypeSsrc,
+ rtc::ToString<uint32_t>(ssrc_),
+ StatsReport::kSend);
+}
+
+void VideoRtpSender::ReportStats(StatsReport* report) {
+ if (track_) {
tommi 2016/03/30 11:46:44 early returns are preferred. i.e.: if (!track_)
nisse-webrtc 2016/03/30 12:09:31 Done.
+ VideoTrackSourceInterface::Stats stats;
perkj_webrtc 2016/03/29 11:03:39 Why not skip VideoTrackSourceInterface::Stats all
nisse-webrtc 2016/03/29 11:37:31 I don't quite like adding dependencies to StatsRep
+ if (track_->GetSource()->GetStats(&stats)) {
+ report->AddInt(StatsReport::kStatsValueNameFrameWidthInput,
+ stats.input_width);
+ report->AddInt(StatsReport::kStatsValueNameFrameHeightInput,
+ stats.input_height);
+ }
+ }
+}
+
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698