Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1827013002:
Fixed a potential deadlock problem in the AGC. (Closed)
|
Created:
4 years, 9 months ago by peah-webrtc Modified:
4 years, 9 months ago Reviewers:
the sun CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFixed a potential deadlock problem in the AGC
where the render and capture locks were
acquired in the wrong order.
BUG=webrtc:5339
Committed: https://crrev.com/7c931ad698bb90ec7a8f37bb045a1358751c619b
Cr-Commit-Position: refs/heads/master@{#12122}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Moved parameter checks to outside of the critical section #Messages
Total messages: 19 (10 generated)
peah@webrtc.org changed reviewers: + solenberg@webrtc.org
Description was changed from ========== Fixed a potential deadlock problem in the AGC. BUG= ========== to ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG= ==========
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827013002/1
Description was changed from ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG= ========== to ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG=webrtc:5339 ==========
lgtm https://codereview.webrtc.org/1827013002/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/gain_control_impl.cc (right): https://codereview.webrtc.org/1827013002/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/gain_control_impl.cc:343: if (minimum < 0) { All parameter checking should go first in the function, before taking the critsect.
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org Link to the patchset: https://codereview.webrtc.org/1827013002/#ps20001 (title: "Moved parameter checks to outside of the critical section")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827013002/20001
https://codereview.webrtc.org/1827013002/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/gain_control_impl.cc (right): https://codereview.webrtc.org/1827013002/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/gain_control_impl.cc:343: if (minimum < 0) { On 2016/03/24 12:29:29, the sun wrote: > All parameter checking should go first in the function, before taking the > critsect. Good point! Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827013002/20001
Message was sent while issue was closed.
Description was changed from ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG=webrtc:5339 ========== to ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG=webrtc:5339 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG=webrtc:5339 ========== to ========== Fixed a potential deadlock problem in the AGC where the render and capture locks were acquired in the wrong order. BUG=webrtc:5339 Committed: https://crrev.com/7c931ad698bb90ec7a8f37bb045a1358751c619b Cr-Commit-Position: refs/heads/master@{#12122} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7c931ad698bb90ec7a8f37bb045a1358751c619b Cr-Commit-Position: refs/heads/master@{#12122} |
