Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: webrtc/build/common.gypi

Issue 1826453004: Add visibility flag to GYP. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/ios/build_ios_libs.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/build/common.gypi
diff --git a/webrtc/build/common.gypi b/webrtc/build/common.gypi
index a349d11088644adc182a818c2b21296baeeb5573..33427065c6e22306db2dd10935b6459ab68f45df 100644
--- a/webrtc/build/common.gypi
+++ b/webrtc/build/common.gypi
@@ -141,6 +141,12 @@
# Enabling this may break interop with Android clients that support H264.
'use_objc_h264%': 0,
+ # Enable this to prevent extern symbols from being hidden on iOS builds.
+ # The chromium settings we inherit hide symbols by default on Release
+ # builds. We want our symbols to be visible when distributing WebRTC via
+ # static libraries to avoid linker warnings.
+ 'override_visibility%': 0,
kjellander_webrtc 2016/03/23 18:26:24 can we name this override_ios_visibility or ios_ov
+
# Determines whether QUIC code will be built.
'use_quic%': 0,
@@ -380,6 +386,12 @@
'WEBRTC_IOS',
],
}],
+ ['OS=="ios" and override_visibility==1', {
+ 'xcode_settings': {
+ 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'NO',
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
+ }
+ }],
['OS=="ios" and use_objc_h264==1', {
'defines': [
'WEBRTC_OBJC_H264',
« no previous file with comments | « no previous file | webrtc/build/ios/build_ios_libs.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698