Add visibility flag to GYP.

Add visibility flag to GYP.

BUG=

Committed: https://crrev.com/1bd9553d2e02197666a571b3b987c9f189495666
Cr-Commit-Position: refs/heads/master@{#12108}

[tkchin_webrtc, 2016-03-23 06:38:43]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-03-23 06:38:55]

Description was changed from

==========
Add visibility flag to GYP.

BUG=
==========

to

==========
Add visibility flag to GYP.

BUG=
==========

[tkchin_webrtc, 2016-03-23 06:38:55]

tkchin@webrtc.org changed reviewers:
+ hjon@webrtc.org, kjellander@webrtc.org

[hjon_webrtc, 2016-03-23 14:48:56]

lgtm

Out of curiosity, was this motivated by the issues we ran into when building a
framework or are there other reasons for this change?

[tkchin_webrtc, 2016-03-23 17:33:24]

On 2016/03/23 14:48:56, hjon_webrtc wrote:
> lgtm
> 
> Out of curiosity, was this motivated by the issues we ran into when building a
> framework or are there other reasons for this change?

Just avoids linker warnings if you are eating webrtc as static libraries. In
framework you are compiling with both of those options set to YES (or should be)
so it may not matter.

[kjellander_webrtc, 2016-03-23 18:26:24]

lgtm with a renaming suggestion though.

https://codereview.webrtc.org/1826453004/diff/20001/webrtc/build/common.gypi
File webrtc/build/common.gypi (right):

https://codereview.webrtc.org/1826453004/diff/20001/webrtc/build/common.gypi#...
webrtc/build/common.gypi:148: 'override_visibility%': 0,
can we name this override_ios_visibility or ios_override_visibility instead?

[tkchin_webrtc, 2016-03-23 18:33:34]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-23 18:33:35]

The patchset sent to the CQ was uploaded after l-g-t-m from hjon@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1826453004/#ps40001 (title:
"Rename gyp var")

[commit-bot: I haz the power, 2016-03-23 18:33:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826453004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826453004/40001

[commit-bot: I haz the power, 2016-03-23 20:19:21]

Description was changed from

==========
Add visibility flag to GYP.

BUG=
==========

to

==========
Add visibility flag to GYP.

BUG=
==========

[commit-bot: I haz the power, 2016-03-23 20:19:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-23 20:19:25]

Description was changed from

==========
Add visibility flag to GYP.

BUG=
==========

to

==========
Add visibility flag to GYP.

BUG=

Committed: https://crrev.com/1bd9553d2e02197666a571b3b987c9f189495666
Cr-Commit-Position: refs/heads/master@{#12108}
==========

[commit-bot: I haz the power, 2016-03-23 20:19:26]

Patchset 2 (id:??) landed as
https://crrev.com/1bd9553d2e02197666a571b3b987c9f189495666
Cr-Commit-Position: refs/heads/master@{#12108}