Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1825713003: Remove WEBRTC_IOS from RTCPeerConnectionFactory public header. (Closed)

Created:
4 years, 9 months ago by tkchin_webrtc
Modified:
4 years, 9 months ago
Reviewers:
hjon_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove WEBRTC_IOS from RTCPeerConnectionFactory public header. We shouldn't make external users define this flag to use our file. BUG= Committed: https://crrev.com/24a62d5d83c5b5b58e77433a7373d42af5c6d565 Cr-Commit-Position: refs/heads/master@{#12106}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M webrtc/api/objc/RTCPeerConnectionFactory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/api/objc/RTCPeerConnectionFactory.mm View 1 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/base/objc/RTCMacros.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
tkchin_webrtc
4 years, 9 months ago (2016-03-23 06:40:41 UTC) #4
hjon_webrtc
lgtm (with one nit) https://codereview.webrtc.org/1825713003/diff/20001/webrtc/api/objc/RTCPeerConnectionFactory.mm File webrtc/api/objc/RTCPeerConnectionFactory.mm (right): https://codereview.webrtc.org/1825713003/diff/20001/webrtc/api/objc/RTCPeerConnectionFactory.mm#newcode55 webrtc/api/objc/RTCPeerConnectionFactory.mm:55: #endif Indent :-)
4 years, 9 months ago (2016-03-23 15:01:28 UTC) #5
Chuck
lgtm % the indent comment
4 years, 9 months ago (2016-03-23 15:10:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825713003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825713003/40001
4 years, 9 months ago (2016-03-23 17:30:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-23 18:29:31 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 18:29:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24a62d5d83c5b5b58e77433a7373d42af5c6d565
Cr-Commit-Position: refs/heads/master@{#12106}

Powered by Google App Engine
This is Rietveld 408576698