Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 1825353002: [rtcp] SenderReport::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 9 months ago by danilchap
Modified:
4 years, 8 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] SenderReport::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/2f36c2399e6747152643fdc999cecff2767ab112 Cr-Commit-Position: refs/heads/master@{#12140}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -63 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc View 1 4 chunks +51 lines, -51 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
åsapersson
lgtm https://codereview.webrtc.org/1825353002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc (right): https://codereview.webrtc.org/1825353002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc#newcode64 webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc:64: TEST(RtcpPacketSenderReportTest, WithOneReportBlock) { maybe CreateAndParseWithOneReportBlock https://codereview.webrtc.org/1825353002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc#newcode81 webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc:81: TEST(RtcpPacketSenderReportTest, ...
4 years, 8 months ago (2016-03-29 12:11:23 UTC) #1
danilchap
https://codereview.webrtc.org/1825353002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc File webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc (right): https://codereview.webrtc.org/1825353002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc#newcode64 webrtc/modules/rtp_rtcp/source/rtcp_packet/sender_report_unittest.cc:64: TEST(RtcpPacketSenderReportTest, WithOneReportBlock) { On 2016/03/29 12:11:23, åsapersson wrote: > ...
4 years, 8 months ago (2016-03-29 12:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825353002/20001
4 years, 8 months ago (2016-03-29 15:01:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-29 15:02:31 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 15:02:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f36c2399e6747152643fdc999cecff2767ab112
Cr-Commit-Position: refs/heads/master@{#12140}

Powered by Google App Engine
This is Rietveld 408576698