Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1824763003: Reland of VCMCodecTimer: Change filter from max to 95th percentile (Closed)

Created:
4 years, 9 months ago by magjed_webrtc
Modified:
4 years, 9 months ago
Reviewers:
philipel, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of VCMCodecTimer: Change filter from max to 95th percentile (patchset #1 id:1 of https://codereview.webrtc.org/1808693002/ ) This CL is expected to lower goog_max_decode_ms and total_delay_incl_network/receiver_time for screenshare. Reason for revert: This CL did not cause the unexpected goog_encode_usage_percent and goog_avg_encode_ms perf changes. Original issue's description: > Revert of VCMCodecTimer: Change filter from max to 95th percentile (patchset #5 id:180001 of https://codereview.webrtc.org/1742323002/ ) > > Reason for revert: > Caused unexpected perf stats changes, see http://crbug/594575. > > Original issue's description: > > VCMCodecTimer: Change filter from max to 95th percentile > > > > The purpose with this change is to make the filter more robust against anomalies. googMaxDecodeMs is expected to drop a litte by this. > > > > BUG=b/27306053 > > > > Committed: https://crrev.com/4bf0c717740d1834e810ea5f32b3c4306c64235f > > Cr-Commit-Position: refs/heads/master@{#11952} > > TBR=stefan@webrtc.org,philipel@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=594575 ,b/27306053 > > Committed: https://crrev.com/c4a74e95b545f4752d4e72961ac03c1380d4bc1f > Cr-Commit-Position: refs/heads/master@{#12018} TBR=stefan@webrtc.org,philipel@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594575 ,b/27306053 Committed: https://crrev.com/2943f015b6f7b88a765264f76c19cd56e174cd00 Cr-Commit-Position: refs/heads/master@{#12087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -120 lines) Patch
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codec_timer.h View 1 chunk +19 lines, -25 lines 0 comments Download
M webrtc/modules/video_coding/codec_timer.cc View 1 chunk +31 lines, -71 lines 0 comments Download
A webrtc/modules/video_coding/percentile_filter.h View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/percentile_filter.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A webrtc/modules/video_coding/percentile_filter_unittest.cc View 1 chunk +104 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/timing.h View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/timing.cc View 10 chunks +21 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/timing_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
magjed_webrtc
Created Reland of VCMCodecTimer: Change filter from max to 95th percentile
4 years, 9 months ago (2016-03-22 09:39:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824763003/1
4 years, 9 months ago (2016-03-22 09:46:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 12:12:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 12:12:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2943f015b6f7b88a765264f76c19cd56e174cd00
Cr-Commit-Position: refs/heads/master@{#12087}

Powered by Google App Engine
This is Rietveld 408576698