Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1824583003: Revert of Added a bitexactness test for the echo canceller in the audio processing module. (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@VadBitExactness_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added a bitexactness test for the echo canceller in the audio processing module. (patchset #3 id:60001 of https://codereview.webrtc.org/1809613002/ ) Reason for revert: The tests in the CL are failing on the bots in the Webrtc Waterfall (allthough they did not fail on the commit bots). I will therefore revise and reland the test. Original issue's description: > Added a bitexactness test for the echo canceller in the audio processing module. > > BUG=webrtc:5337 > > Committed: https://crrev.com/7c448e1a384224aa16a21715e83574f3f553b730 > Cr-Commit-Position: refs/heads/master@{#12068} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5337 Committed: https://crrev.com/f26f98b29c28dd8a8a5906a809bde53b8aa89d10 Cr-Commit-Position: refs/heads/master@{#12072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -353 lines) Patch
D webrtc/modules/audio_processing/echo_cancellation_unittest.cc View 1 chunk +0 lines, -352 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
peah-webrtc
Created Revert of Added a bitexactness test for the echo canceller in the audio processing ...
4 years, 9 months ago (2016-03-21 09:20:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824583003/1
4 years, 9 months ago (2016-03-21 09:20:42 UTC) #2
commit-bot: I haz the power
Failed to apply patch for webrtc/modules/modules.gyp: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-21 09:20:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824583003/1
4 years, 9 months ago (2016-03-21 09:25:42 UTC) #6
commit-bot: I haz the power
Failed to apply patch for webrtc/modules/modules.gyp: While running git apply --index -3 -p1; error: patch ...
4 years, 9 months ago (2016-03-21 09:25:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824583003/1
4 years, 9 months ago (2016-03-21 09:34:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 09:35:22 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f26f98b29c28dd8a8a5906a809bde53b8aa89d10 Cr-Commit-Position: refs/heads/master@{#12072}
4 years, 9 months ago (2016-03-21 09:35:32 UTC) #13
hlundin-webrtc
4 years, 8 months ago (2016-03-29 19:49:21 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698