webrtc/media/base/rtpdataengine.h - Issue 1823503002: Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/rtpdataengine.h

Issue 1823503002: Reland Use CopyOnWriteBuffer instead of Buffer to avoid unnecessary copies. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/rtpdataengine.h

diff --git a/webrtc/media/base/rtpdataengine.h b/webrtc/media/base/rtpdataengine.h

index 62eebf63c1247291b96356dfa4dbb32a98ec4e32..0181e65759f03b5a1f2650302253be3e3c7b8190 100644

--- a/webrtc/media/base/rtpdataengine.h

+++ b/webrtc/media/base/rtpdataengine.h

@@ -93,14 +93,14 @@ class RtpDataMediaChannel : public DataMediaChannel {

receiving_ = receive;

return true;

}

- virtual void OnPacketReceived(rtc::Buffer* packet,

+ virtual void OnPacketReceived(rtc::CopyOnWriteBuffer* packet,

const rtc::PacketTime& packet_time);

- virtual void OnRtcpReceived(rtc::Buffer* packet,

+ virtual void OnRtcpReceived(rtc::CopyOnWriteBuffer* packet,

const rtc::PacketTime& packet_time) {}

virtual void OnReadyToSend(bool ready) {}

virtual bool SendData(

const SendDataParams& params,

- const rtc::Buffer& payload,

+ const rtc::CopyOnWriteBuffer& payload,

SendDataResult* result);

private:

« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/base/rtpdataengine.cc » ('j') | webrtc/media/sctp/sctpdataengine.cc » ('J')