Support delayed AudioUnit initialization.

Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
R=haysc@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/307a0922c536317f04ff05fe8a8d4bc3ea75b487

[tkchin_webrtc, 2016-03-20 06:03:39]

Description was changed from

==========
Support delayed AudioUnit initialization.

BUG=
==========

to

==========
Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
==========

[tkchin_webrtc, 2016-03-20 06:03:40]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org

[tkchin_webrtc, 2016-03-21 04:19:16]

Patchset #1 (id:1) has been deleted

[Chuck, 2016-03-21 17:12:48]

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:46: // [self
dismissViewControllerAnimated:NO completion:nil];
Did you mean to remove this? Add a comment if not.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:149:
[[RTCAudioSessionConfiguration alloc] init];
indent

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:166: [[NSBundle
mainBundle] pathForResource:@"mozart" ofType:@"mp3"];
indent

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.h (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.h:32: *  interruption event
on the system.
nit: on the system seems out of place here since the others don't have it.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm:237:
RTC_DCHECK_GE(state_, kUninitialized);
Should these be GE initialized instead of uninitialized? Here and 250/263

[tkchin_webrtc, 2016-03-21 18:32:27]

PTAL

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
File webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:46: // [self
dismissViewControllerAnimated:NO completion:nil];
On 2016/03/21 17:12:48, Chuck wrote:
> Did you mean to remove this? Add a comment if not.

Nope! Although there isn't a reason to dismiss it now that we handle
backgrounding. Removing it.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:149:
[[RTCAudioSessionConfiguration alloc] init];
On 2016/03/21 17:12:48, Chuck wrote:
> indent

Done.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/examples/objc/AppR...
webrtc/examples/objc/AppRTCDemo/ios/ARDMainViewController.m:166: [[NSBundle
mainBundle] pathForResource:@"mozart" ofType:@"mp3"];
On 2016/03/21 17:12:48, Chuck wrote:
> indent

Done.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/objc/RTCAudioSession.h (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/objc/RTCAudioSession.h:32: *  interruption event
on the system.
On 2016/03/21 17:12:48, Chuck wrote:
> nit: on the system seems out of place here since the others don't have it.

Done.

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm (right):

https://codereview.webrtc.org/1822543002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/ios/voice_processing_audio_unit.mm:237:
RTC_DCHECK_GE(state_, kUninitialized);
On 2016/03/21 17:12:48, Chuck wrote:
> Should these be GE initialized instead of uninitialized? Here and 250/263

No, because we don't want to make callers have to check state before calling
methods. Sometimes audio unit calls can fail, and we should just fail
gracefully.

[Chuck, 2016-03-21 18:42:01]

lgtm

[tkchin_webrtc, 2016-03-21 19:33:26]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-21 19:33:27]

The patchset sent to the CQ was uploaded after l-g-t-m from haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1822543002/#ps80001 (title:
"Minor fixes.")

[commit-bot: I haz the power, 2016-03-21 19:33:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822543002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822543002/80001

[commit-bot: I haz the power, 2016-03-21 20:09:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:09:39]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[tkchin_webrtc, 2016-03-21 20:22:40]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-21 20:22:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1822543002/#ps100001 (title:
"Rebase")

[commit-bot: I haz the power, 2016-03-21 20:22:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822543002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822543002/100001

[commit-bot: I haz the power, 2016-03-21 20:56:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 20:56:01]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/11928)

[commit-bot: I haz the power, 2016-03-21 20:58:05]

Description was changed from

==========
Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
==========

to

==========
Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
R=haysc@webrtc.org

Committed: https://crrev.com/307a0922c536317f04ff05fe8a8d4bc3ea75b487
Cr-Commit-Position: refs/heads/master@{#12080}
==========

[commit-bot: I haz the power, 2016-03-21 20:58:06]

Patchset 5 (id:??) landed as
https://crrev.com/307a0922c536317f04ff05fe8a8d4bc3ea75b487
Cr-Commit-Position: refs/heads/master@{#12080}

[tkchin_webrtc, 2016-03-21 20:58:07]

Description was changed from

==========
Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
R=haysc@webrtc.org

Committed: https://crrev.com/307a0922c536317f04ff05fe8a8d4bc3ea75b487
Cr-Commit-Position: refs/heads/master@{#12080}
==========

to

==========
Support delayed AudioUnit initialization.

Applications can choose to decide when to give up control of the
AVAudioSession to WebRTC. Otherwise, behavior should be
unchanged.

Adds a toggle to AppRTCDemo so developers can see the different
paths.

BUG=
R=haysc@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/307a0922c536317f04ff05fe8...
==========

[tkchin_webrtc, 2016-03-21 20:58:08]

Committed patchset #5 (id:100001) manually as
307a0922c536317f04ff05fe8a8d4bc3ea75b487 (presubmit successful).