New method I420Buffer::Copy.

New method I420Buffer::Copy.

Needed to replace cricket::VideoFrame::MakeExclusive in chromium.

BUG=webrtc:5682
Committed: https://crrev.com/7cc9cc0460b9828fa5c139ecb79cf568824e6dac
Cr-Commit-Position: refs/heads/master@{#12155}

[nisse-webrtc, 2016-03-23 12:37:04]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org

[perkj_webrtc, 2016-03-23 14:38:09]

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:84: virtual
rtc::scoped_refptr<I420Buffer> Copy();
Can we move this to be a helper method. ie. Move to below ShalloCenterCrop. 
Call it  rtc::scoped_refptr<VideoFrameBuffer> CopyI420Buffer(const
rtc::scoped_refptr<I420Buffer>& buffer);

[nisse-webrtc, 2016-03-24 12:52:52]

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:84: virtual
rtc::scoped_refptr<I420Buffer> Copy();
On 2016/03/23 14:38:09, perkj_webrtc wrote:
> Can we move this to be a helper method. ie. Move to below ShalloCenterCrop. 
> Call it  rtc::scoped_refptr<VideoFrameBuffer> CopyI420Buffer(const
> rtc::scoped_refptr<I420Buffer>& buffer);

For my intended usecase, it's desirable that the return value is an I420Buffer.

[perkj_webrtc, 2016-03-24 13:18:42]

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
File webrtc/common_video/include/video_frame_buffer.h (right):

https://codereview.webrtc.org/1822283002/diff/1/webrtc/common_video/include/v...
webrtc/common_video/include/video_frame_buffer.h:84: virtual
rtc::scoped_refptr<I420Buffer> Copy();
On 2016/03/24 12:52:52, nisse-webrtc wrote:
> On 2016/03/23 14:38:09, perkj_webrtc wrote:
> > Can we move this to be a helper method. ie. Move to below ShalloCenterCrop. 
> > Call it  rtc::scoped_refptr<VideoFrameBuffer> CopyI420Buffer(const
> > rtc::scoped_refptr<I420Buffer>& buffer);
> 
> For my intended usecase, it's desirable that the return value is an
I420Buffer. 

that is fine. But add a helper function instead of a memeber method?

[perkj_webrtc, 2016-03-29 11:14:06]

On 2016/03/29 09:09:12, nisse-webrtc wrote:

lgtm

[nisse-webrtc, 2016-03-29 13:21:33]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-03-29 13:21:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822283002/20001

[commit-bot: I haz the power, 2016-03-29 13:33:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 13:33:12]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4444)

[pbos-webrtc, 2016-03-29 14:00:37]

lgtm

https://codereview.webrtc.org/1822283002/diff/20001/webrtc/common_video/video...
File webrtc/common_video/video_frame_buffer.cc (right):

https://codereview.webrtc.org/1822283002/diff/20001/webrtc/common_video/video...
webrtc/common_video/video_frame_buffer.cc:128:
libyuv::I420Copy(buffer->data(kYPlane), buffer->stride(kYPlane),
pref RTC_CHECK_EQ or == 0 after

[nisse-webrtc, 2016-03-29 14:18:15]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-29 14:18:16]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1822283002/#ps40001 (title:
"Address compare nit.")

[commit-bot: I haz the power, 2016-03-29 14:18:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822283002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822283002/40001

[commit-bot: I haz the power, 2016-03-29 16:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 16:19:00]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[nisse-webrtc, 2016-03-30 06:42:52]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-03-30 06:42:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1822283002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1822283002/40001

[commit-bot: I haz the power, 2016-03-30 06:44:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-30 06:44:27]

Description was changed from

==========
New method I420Buffer::Copy.

Needed to replace cricket::VideoFrame::MakeExclusive in chromium.

BUG=webrtc:5682
==========

to

==========
New method I420Buffer::Copy.

Needed to replace cricket::VideoFrame::MakeExclusive in chromium.

BUG=webrtc:5682

Committed: https://crrev.com/7cc9cc0460b9828fa5c139ecb79cf568824e6dac
Cr-Commit-Position: refs/heads/master@{#12155}
==========

[commit-bot: I haz the power, 2016-03-30 06:44:28]

Patchset 3 (id:??) landed as
https://crrev.com/7cc9cc0460b9828fa5c139ecb79cf568824e6dac
Cr-Commit-Position: refs/heads/master@{#12155}