Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1821983002: Revert of Initialize/configure video encoders asychronously. (Closed)

Created:
4 years, 9 months ago by pbos-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman, Pawel Osciak, wuchengli
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Initialize/configure video encoders asychronously. (patchset #4 id:60001 of https://codereview.webrtc.org/1757313002/ ) Reason for revert: Breaks RTCVideoEncoder which has incorrect assumptions on where InitEncode etc. is called from. Temporarily reverting until RTCVideoEncoder has been updated. Original issue's description: > Initialize/configure video encoders asychronously. > > Greatly speeds up setRemoteDescription() by moving encoder initialization > off the main worker thread, which is free to move onto gathering ICE > candidates and other tasks while InitEncode() is performed. It also > un-blocks PeerConnection GetStats() which is no longer blocked on > encoder initialization. > > BUG=webrtc:5410 > R=stefan@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/fb647a67be94bb3c940d8b5fba01972f7ce91a29 R=stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:595274, chromium:595308, webrtc:5410 Committed: https://crrev.com/81cbd924447d507559dbd6e6d1f9fe439fcf2716 Cr-Commit-Position: refs/heads/master@{#12086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -309 lines) Patch
M webrtc/media/engine/fakewebrtcvideoengine.h View 6 chunks +10 lines, -32 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 6 chunks +4 lines, -11 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 10 chunks +7 lines, -36 lines 0 comments Download
M webrtc/video/video_send_stream.h View 3 chunks +0 lines, -8 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 4 chunks +150 lines, -186 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 15 chunks +5 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pbos-webrtc
Created Revert of Initialize/configure video encoders asychronously.
4 years, 9 months ago (2016-03-22 10:25:14 UTC) #1
stefan-webrtc
lgtm
4 years, 9 months ago (2016-03-22 10:26:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1821983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1821983002/1
4 years, 9 months ago (2016-03-22 10:29:51 UTC) #5
pbos-webrtc
Committed patchset #1 (id:1) manually as 81cbd924447d507559dbd6e6d1f9fe439fcf2716 (presubmit successful).
4 years, 9 months ago (2016-03-22 11:19:21 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/81cbd924447d507559dbd6e6d1f9fe439fcf2716 Cr-Commit-Position: refs/heads/master@{#12086}
4 years, 9 months ago (2016-03-22 11:19:26 UTC) #10
pbos-webrtc
4 years, 8 months ago (2016-04-20 09:45:30 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1896413002/ by pbos@webrtc.org.

The reason for reverting is: RTCVideoEncoder has been updated to not make
assumptions on calling threads/post back to a worker thread. This should now be
landable again..

Powered by Google App Engine
This is Rietveld 408576698