Chromium Code Reviews

Unified Diff: webrtc/modules/audio_processing/noise_suppression_impl.cc

Issue 1821443003: Fix normalization of noise estimate in NoiseSuppressor (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Normalize dynamically Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/audio_processing/noise_suppression_impl.cc
diff --git a/webrtc/modules/audio_processing/noise_suppression_impl.cc b/webrtc/modules/audio_processing/noise_suppression_impl.cc
index a9d9f4a93bbf8086105ea4cb28fc0ee181be644b..555c6a9b98b7e36431c56896f1e55695e38f164c 100644
--- a/webrtc/modules/audio_processing/noise_suppression_impl.cc
+++ b/webrtc/modules/audio_processing/noise_suppression_impl.cc
@@ -177,23 +177,19 @@ std::vector<float> NoiseSuppressionImpl::NoiseEstimate() {
rtc::CritScope cs(crit_);
std::vector<float> noise_estimate;
#if defined(WEBRTC_NS_FLOAT)
- const float kNormalizationFactor = 1.f / (1 << 15);
noise_estimate.assign(WebRtcNs_num_freq(), 0.f);
for (auto& suppressor : suppressors_) {
const float* noise = WebRtcNs_noise_estimate(suppressor->state());
for (size_t i = 0; i < noise_estimate.size(); ++i) {
- noise_estimate[i] +=
- kNormalizationFactor * noise[i] / suppressors_.size();
+ noise_estimate[i] += noise[i] / suppressors_.size();
}
}
#elif defined(WEBRTC_NS_FIXED)
- const float kNormalizationFactor = 1.f / (1 << 23);
noise_estimate.assign(WebRtcNsx_num_freq(), 0.f);
for (auto& suppressor : suppressors_) {
- const uint32_t* noise = WebRtcNsx_noise_estimate(suppressor->state());
+ const uint16_t* noise = WebRtcNsx_noise_estimate(suppressor->state());
for (size_t i = 0; i < noise_estimate.size(); ++i) {
- noise_estimate[i] += kNormalizationFactor *
- static_cast<float>(noise[i]) / suppressors_.size();
+ noise_estimate[i] += static_cast<float>(noise[i]) / suppressors_.size();
}
}
#endif

Powered by Google App Engine