Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Issue 1820643002: Move copyonwritebuffer to rtc_base_approved. (Closed)

Created:
4 years, 9 months ago by tommi
Modified:
4 years, 9 months ago
Reviewers:
joachim
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move copyonwritebuffer to rtc_base_approved. The other buffer classes as well as all other dependencies are in rtc_base_approved, so I think this is a better place for it. Additionally I found that code in Chromium that already depends on the other buffer classes but now depends on the CopyOnWriteBuffer class, needed to have their build files updated and they previously depended on the buffer classes in rtc_base_approved. TBR=jbauch@webrtc.org Committed: https://crrev.com/ebfbab50596e3861f936654e7f46385939084266 Cr-Commit-Position: refs/heads/master@{#12059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/base/base.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommi
4 years, 9 months ago (2016-03-19 17:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820643002/1
4 years, 9 months ago (2016-03-19 17:36:54 UTC) #3
joachim
lgtm
4 years, 9 months ago (2016-03-19 17:43:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 18:36:24 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 18:36:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebfbab50596e3861f936654e7f46385939084266
Cr-Commit-Position: refs/heads/master@{#12059}

Powered by Google App Engine
This is Rietveld 408576698