Refactor some ObjC API init methods.

Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
R=haysc@webrtc.org, hjon@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/f3cb49f3ef944f953603d2a2e80f5f9447c30434

[tkchin_webrtc, 2016-03-22 05:17:19]

Description was changed from

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

BUG=
==========

to

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

BUG=
==========

[tkchin_webrtc, 2016-03-22 05:17:19]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, hjon@webrtc.org

[tkchin_webrtc, 2016-03-22 05:20:55]

Description was changed from

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

BUG=
==========

to

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
==========

[tkchin_webrtc, 2016-03-22 05:24:48]

Patchset #1 (id:1) has been deleted

[kjellander_webrtc, 2016-03-22 10:24:22]

On 2016/03/22 05:27:53, tkchin_webrtc wrote:

Android failures caused by https://codereview.chromium.org/1818083003/ which has
now been reverted. Feel free to ignore those.

[Chuck, 2016-03-22 15:27:01]

lgtm

[tkchin_webrtc, 2016-03-22 15:54:45]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-22 15:54:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820193002/20001

[hjon_webrtc, 2016-03-22 16:20:45]

On 2016/03/22 05:27:53, tkchin_webrtc wrote:

lgtm

[tkchin_webrtc, 2016-03-22 17:09:11]

On 2016/03/22 10:24:22, kjellander (webrtc) wrote:
> On 2016/03/22 05:27:53, tkchin_webrtc wrote:
> 
> Android failures caused by https://codereview.chromium.org/1818083003/ which
has
> now been reverted. Feel free to ignore those.

Is there a good way to just run the required bots? I feel like I am often
blocked from checking in by android / win bots, when my changes only affect
ios/mac code.

[commit-bot: I haz the power, 2016-03-22 17:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-22 17:55:17]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin_webrtc, 2016-03-22 17:58:09]

Description was changed from

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
==========

to

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
R=haysc@webrtc.org, hjon@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f3cb49f3ef944f953603d2a2e...
==========

[commit-bot: I haz the power, 2016-03-22 17:58:11]

Description was changed from

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
R=haysc@webrtc.org, hjon@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/f3cb49f3ef944f953603d2a2e...
==========

to

==========
Refactor some ObjC API init methods.

initWithFactory: is clumsy and makes classes difficult to mock out in
tests. By keeping methods on the factory, we can simply mock out the
factory's methods instead.

We can consider adding regular Obj-C like ctors if we move to making
the factory a singleton, but that requires further discussion.

BUG=
R=haysc@webrtc.org, hjon@webrtc.org

Committed: https://crrev.com/f3cb49f3ef944f953603d2a2e80f5f9447c30434
Cr-Commit-Position: refs/heads/master@{#12089}
==========

[tkchin_webrtc, 2016-03-22 17:58:11]

Committed patchset #1 (id:20001) manually as
f3cb49f3ef944f953603d2a2e80f5f9447c30434 (presubmit successful).

[commit-bot: I haz the power, 2016-03-22 17:58:11]

Patchset 1 (id:??) landed as
https://crrev.com/f3cb49f3ef944f953603d2a2e80f5f9447c30434
Cr-Commit-Position: refs/heads/master@{#12089}