Chromium Code Reviews

Issue 1820113003: Add Mic Toggle button to AppRTCDemo (Android). (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add Mic Toggle button to AppRTCDemo (Android). BUG=webrtc:5671 Committed: https://crrev.com/de3185521b5e31bae14c6c4c523965a2a60e04eb Cr-Commit-Position: refs/heads/master@{#12100}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Stats (+58 lines, -3 lines)
M webrtc/examples/androidapp/res/layout/fragment_call.xml View 1 chunk +8 lines, -0 lines 0 comments
M webrtc/examples/androidapp/res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 2 chunks +10 lines, -0 lines 0 comments
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java View 4 chunks +12 lines, -0 lines 0 comments
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 6 chunks +27 lines, -3 lines 0 comments

Messages

Total messages: 14 (6 generated)
the sun
4 years, 9 months ago (2016-03-22 12:08:39 UTC) #2
AlexG
lgtm https://codereview.webrtc.org/1820113003/diff/1/webrtc/examples/androidapp/res/layout/fragment_call.xml File webrtc/examples/androidapp/res/layout/fragment_call.xml (right): https://codereview.webrtc.org/1820113003/diff/1/webrtc/examples/androidapp/res/layout/fragment_call.xml#newcode54 webrtc/examples/androidapp/res/layout/fragment_call.xml:54: android:contentDescription="@string/switch_camera" nit: Add new content description string for ...
4 years, 9 months ago (2016-03-22 16:49:20 UTC) #3
the sun
https://codereview.webrtc.org/1820113003/diff/1/webrtc/examples/androidapp/res/layout/fragment_call.xml File webrtc/examples/androidapp/res/layout/fragment_call.xml (right): https://codereview.webrtc.org/1820113003/diff/1/webrtc/examples/androidapp/res/layout/fragment_call.xml#newcode54 webrtc/examples/androidapp/res/layout/fragment_call.xml:54: android:contentDescription="@string/switch_camera" On 2016/03/22 16:49:20, AlexG wrote: > nit: Add ...
4 years, 9 months ago (2016-03-23 08:25:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820113003/20001
4 years, 9 months ago (2016-03-23 08:43:24 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 09:50:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820113003/20001
4 years, 9 months ago (2016-03-23 09:54:28 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 09:57:10 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 09:57:17 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de3185521b5e31bae14c6c4c523965a2a60e04eb
Cr-Commit-Position: refs/heads/master@{#12100}

Powered by Google App Engine