Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 1820023004: Remove all uses of the HAVE_CONFIG_H define. (Closed)

Created:
4 years, 9 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove all uses of the HAVE_CONFIG_H define. BUG= R=henrik.lundin@webrtc.org, pthatcher@google.com, stefan@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/b252856d10a227ae2497e583ea07fda8c1ed6332 Cr-Commit-Position: refs/heads/master@{#12141}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -87 lines) Patch
M webrtc/base/basictypes.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/logging.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/network.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/openssladapter.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/opensslstreamadapter.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/physicalsocketserver.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/base/proxydetect.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/proxydetect.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/ssladapter.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/sslidentity.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/sslstreamadapter.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A webrtc/base/sslstreamadapterhelper.cc View 1 1 chunk +140 lines, -0 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppsocket.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/base/mediaengine.cc View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722_decode.c View 7 chunks +7 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/g722_encode.c View 5 chunks +4 lines, -8 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kjellander_webrtc
Adding a bunch of folks to make sure I get enough input on this. Background: ...
4 years, 9 months ago (2016-03-23 19:27:45 UTC) #2
tommi
lgtm
4 years, 9 months ago (2016-03-24 00:10:20 UTC) #3
pthatcher
lgtm, as long as it doesn't break anything, I'm all for deleting unused things.
4 years, 9 months ago (2016-03-25 21:21:03 UTC) #5
stefan-webrtc
lgtm
4 years, 8 months ago (2016-03-29 11:58:46 UTC) #6
hlundin-webrtc
webrtc/modules/audio_coding/codecs/g722: lgtm
4 years, 8 months ago (2016-03-29 15:44:00 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b252856d10a227ae2497e583ea07fda8c1ed6332 Cr-Commit-Position: refs/heads/master@{#12141}
4 years, 8 months ago (2016-03-29 15:47:33 UTC) #9
kjellander_webrtc
4 years, 8 months ago (2016-03-29 15:52:04 UTC) #10
Message was sent while issue was closed.
On 2016/03/29 15:47:33, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/b252856d10a227ae2497e583ea07fda8c1ed6332
> Cr-Commit-Position: refs/heads/master@{#12141}

Sorry about accidentally screwing up the rebase resulting in adding
webrtc/base/sslstreamadapterhelper.cc again. Removing it again in
https://codereview.webrtc.org/1842773002

Powered by Google App Engine
This is Rietveld 408576698