Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1819803002: Revert of Added a bitexactness test for the echo control mobile in the audio processing module (Closed)

Created:
4 years, 9 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@AecBitExactness_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added a bitexactness test for the echo control mobile in the audio processing module (patchset #3 id:60001 of https://codereview.webrtc.org/1805373002/ ) Reason for revert: This needs to be reverted as a previous CL which needs to be reverted causes a merge clash with this CL. Original issue's description: > Added a bitexactness test for the echo control mobile in the audio processing module > > BUG=webrtc:5663 > > Committed: https://crrev.com/105831ef4a38ac49e5e2c1ce207884da0a26c773 > Cr-Commit-Position: refs/heads/master@{#12069} TBR=henrik.lundin@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5663 Committed: https://crrev.com/b60be20957679732b637d9ef44f5942256b0946d Cr-Commit-Position: refs/heads/master@{#12071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -220 lines) Patch
D webrtc/modules/audio_processing/echo_control_mobile_unittest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
peah-webrtc
Created Revert of Added a bitexactness test for the echo control mobile in the audio ...
4 years, 9 months ago (2016-03-21 09:34:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819803002/1
4 years, 9 months ago (2016-03-21 09:34:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 09:34:17 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b60be20957679732b637d9ef44f5942256b0946d Cr-Commit-Position: refs/heads/master@{#12071}
4 years, 9 months ago (2016-03-21 09:34:24 UTC) #5
hlundin-webrtc
4 years, 8 months ago (2016-03-29 19:49:44 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698