Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1819733002: Reland of Delete empty API files and cleaned up includes. (Closed)

Created:
4 years, 9 months ago by perkj_webrtc
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete empty API files and cleaned up includes. (patchset #1 id:1 of https://codereview.webrtc.org/1813083002/ ) Reason for revert: New attempt. Cl for removing videosourceinterface.h dep in chrome is landed here: https://codereview.chromium.org/1810273003/ Original issue's description: > Revert of Delete empty API files and cleaned up includes. (patchset #2 id:20001 of https://codereview.webrtc.org/1809053002/ ) > > Reason for revert: > Breaks Chromium build. Need to remove the references to the obsolete header files from Chromium and reland. > > Original issue's description: > > Delete empty API files and cleaned up includes. > > > > TBR=glaznev@webrtc.org > > > > BUG=webrtc:5426 > > > > Committed: https://crrev.com/c9022f508644dc33c01b05cb22ebfc2be145d6b2 > > Cr-Commit-Position: refs/heads/master@{#12039} > > TBR=nisse@webrtc.org,glaznev@webrtc.org,perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5426 > > Committed: https://crrev.com/246b5273986d5a5b140b3d1a656baa8d40c36276 > Cr-Commit-Position: refs/heads/master@{#12042} TBR=nisse@webrtc.org,glaznev@webrtc.org,deadbeef@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5426 Committed: https://crrev.com/9e083d2ac5989a96f071b16173d4bdec00010aca Cr-Commit-Position: refs/heads/master@{#12065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -165 lines) Patch
M talk/app/webrtc/objc/RTCPeerConnectionFactory.mm View 1 chunk +0 lines, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCVideoCapturer+Internal.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/objc/RTCVideoSource+Internal.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/api.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/api/java/jni/peerconnection_jni.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCVideoSource+Private.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/peerconnection.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/peerconnectionfactory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/remotevideocapturer.h View 1 chunk +0 lines, -16 lines 0 comments Download
D webrtc/api/remotevideocapturer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/api/rtpsender.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/test/peerconnectiontestwrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/api/videosource.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/api/videosource.cc View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/api/videosourceinterface.h View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/api/videosourceproxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/videotrack.h View 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/api/videotrackrenderers.h View 1 chunk +0 lines, -16 lines 0 comments Download
D webrtc/api/videotrackrenderers.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/api/videotracksource.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/conductor.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/media/base/capturemanager.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/media/base/capturemanager.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/media/base/capturerenderadapter.h View 1 chunk +0 lines, -11 lines 0 comments Download
D webrtc/media/base/capturerenderadapter.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
perkj_webrtc
Created Reland of Delete empty API files and cleaned up includes.
4 years, 9 months ago (2016-03-20 15:19:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819733002/1
4 years, 9 months ago (2016-03-20 15:19:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819733002/1
4 years, 9 months ago (2016-03-20 15:31:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819733002/1
4 years, 9 months ago (2016-03-20 16:01:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1819733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1819733002/1
4 years, 9 months ago (2016-03-20 16:31:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-20 16:38:44 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 16:38:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e083d2ac5989a96f071b16173d4bdec00010aca
Cr-Commit-Position: refs/heads/master@{#12065}

Powered by Google App Engine
This is Rietveld 408576698