Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java

Issue 1819553002: Added the JNI interface to get and set RtpParameters and the maximum bitrate limits. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: One more rename Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/java/jni/classreferenceholder.cc » ('j') | webrtc/api/java/jni/jni_helpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java
diff --git a/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java b/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java
index ff98d7d96afc6e9bdac77efc6cf432e8bfe9d29d..5922a69c0774337e4c579fd365ae4ee322bd2252 100644
--- a/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java
+++ b/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java
@@ -694,6 +694,26 @@ public class PeerConnectionTest extends ActivityTestCase {
assertEquals(
PeerConnection.SignalingState.STABLE, answeringPC.signalingState());
+ // Set a bitrate limit for the outgoing video stream for the offerer
+ RtpSender videoSender = null;
+ for (RtpSender sender : offeringPC.getSenders()) {
+ if (sender.track().kind().equals("video")) {
Taylor Brandstetter 2016/03/22 01:16:36 nit: indentation. Unfortunately our Java code does
skvlad 2016/03/22 02:19:59 Done.
+ videoSender = sender;
+ }
+ }
+ assertNotNull(videoSender);
+ RtpParameters rtpParameters = videoSender.getParameters();
+ assertNotNull(rtpParameters);
+ assertEquals(1, rtpParameters.encodings.size());
+ assertNull(rtpParameters.encodings.get(0).maxBitrateBps);
+
+ rtpParameters.encodings.get(0).maxBitrateBps = 300000;
+ assertTrue(videoSender.setParameters(rtpParameters));
+
+ // Verify that we can read back the updated value
Taylor Brandstetter 2016/03/22 01:16:36 nit: Period at end of comment
skvlad 2016/03/22 02:19:59 Done.
+ rtpParameters = videoSender.getParameters();
+ assertEquals(300000, (int) rtpParameters.encodings.get(0).maxBitrateBps);
+
// Test send & receive UTF-8 text.
answeringExpectations.expectMessage(
ByteBuffer.wrap("hello!".getBytes(Charset.forName("UTF-8"))), false);
« no previous file with comments | « no previous file | webrtc/api/java/jni/classreferenceholder.cc » ('j') | webrtc/api/java/jni/jni_helpers.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698