Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1818963002: Use a FakeVideoTrackSource instead of nullptr in all VideoTrack tests. (Closed)

Created:
4 years, 9 months ago by nisse-webrtc
Modified:
4 years, 9 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use a FakeVideoTrackSource instead of nullptr in all VideoTrack tests. Extracted from cl 1790633002. BUG=webrtc:5426 Committed: https://crrev.com/af510afc9192cf927e17285a0abd854de4e6db67 Cr-Commit-Position: refs/heads/master@{#12074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -39 lines) Patch
M webrtc/api/mediastream_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 8 chunks +18 lines, -10 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 9 chunks +10 lines, -26 lines 0 comments Download
M webrtc/api/statscollector_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
A webrtc/api/test/fakevideotracksource.h View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nisse-webrtc
4 years, 9 months ago (2016-03-21 12:18:16 UTC) #2
perkj_webrtc
lgtm
4 years, 9 months ago (2016-03-21 12:55:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1818963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1818963002/1
4 years, 9 months ago (2016-03-21 12:55:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 15:20:48 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 15:20:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/af510afc9192cf927e17285a0abd854de4e6db67
Cr-Commit-Position: refs/heads/master@{#12074}

Powered by Google App Engine
This is Rietveld 408576698