Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: webrtc/api/mediaconstraintsinterface_unittest.cc

Issue 1818033002: Embed a cricket::MediaConfig in RTCConfiguration. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/mediaconstraintsinterface.cc ('k') | webrtc/api/peerconnection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/mediaconstraintsinterface_unittest.cc
diff --git a/webrtc/api/mediaconstraintsinterface_unittest.cc b/webrtc/api/mediaconstraintsinterface_unittest.cc
index 07338c15e823d839142dc38186c50d0c1523c555..dcf4bb7fde700207f4565ea1dafbd38f6824348c 100644
--- a/webrtc/api/mediaconstraintsinterface_unittest.cc
+++ b/webrtc/api/mediaconstraintsinterface_unittest.cc
@@ -17,11 +17,24 @@ namespace webrtc {
namespace {
+// Checks all settings touched by CopyConstraintsIntoRtcConfiguration,
+// plus audio_jitter_buffer_max_packets.
bool Matches(const PeerConnectionInterface::RTCConfiguration& a,
const PeerConnectionInterface::RTCConfiguration& b) {
- return a.audio_jitter_buffer_max_packets ==
+ return a.disable_ipv6 == b.disable_ipv6 &&
+ a.audio_jitter_buffer_max_packets ==
b.audio_jitter_buffer_max_packets &&
- a.disable_prerenderer_smoothing == b.disable_prerenderer_smoothing;
+ a.enable_rtp_data_channel == b.enable_rtp_data_channel &&
+ a.screencast_min_bitrate == b.screencast_min_bitrate &&
+ a.combined_audio_video_bwe == b.combined_audio_video_bwe &&
+ a.enable_dtls_srtp == b.enable_dtls_srtp &&
+ a.media_config.enable_dscp == b.media_config.enable_dscp &&
+ a.media_config.video.enable_cpu_overuse_detection ==
+ b.media_config.video.enable_cpu_overuse_detection &&
+ a.media_config.video.disable_prerenderer_smoothing ==
+ b.media_config.video.disable_prerenderer_smoothing &&
+ a.media_config.video.suspend_below_min_bitrate ==
+ b.media_config.video.suspend_below_min_bitrate;
}
TEST(MediaConstraintsInterface, CopyConstraintsIntoRtcConfiguration) {
« no previous file with comments | « webrtc/api/mediaconstraintsinterface.cc ('k') | webrtc/api/peerconnection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698