Embed a cricket::MediaConfig in RTCConfiguration.

webrtc/api/mediaconstraintsinterface.cc

 /*
  *  Copyright 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 168 matching lines @@
     return;
   }
 
   bool value;
   if (FindConstraint(constraints, MediaConstraintsInterface::kEnableIPv6,
                      &value, nullptr)) {
     if (!value) {
       configuration->disable_ipv6 = true;
     }
   }
-  ConstraintToOptionalBool(constraints, MediaConstraintsInterface::kEnableDscp,
-                           &configuration->enable_dscp);
-  ConstraintToOptionalBool(constraints,
-                           MediaConstraintsInterface::kCpuOveruseDetection,
-                           &configuration->cpu_overuse_detection);
+  FindConstraint(constraints, MediaConstraintsInterface::kEnableDscp,
+                 &configuration->media_config.enable_dscp, nullptr);
+  FindConstraint(
+      constraints, MediaConstraintsInterface::kCpuOveruseDetection,
+      &configuration->media_config.video.enable_cpu_overuse_detection,
+      nullptr);
+  // TODO(nisse): By this logic, it is impossible to disable the flag
+  // using a constraint. Is that intentional?

[hta-webrtc, 2016/03/21 14:38:21]

I suggest you just change this. It was strange last time I went through this,
and it's strange now. This is a smaller CL, so pinpointing this particular issue
if it ever arises should be easy.

I don't think anyone cares about RTP data channels any more (and Chrome has
stopped using the constraints API anyway).

[nisse-webrtc, 2016/03/22 08:33:20]

Done. I'm also renaming value --> enable_ipv6, since that's the only remaining
use.

   if (FindConstraint(constraints,
                      MediaConstraintsInterface::kEnableRtpDataChannels, &value,
-                     NULL) &&
+                     nullptr) &&
       value) {
     configuration->enable_rtp_data_channel = true;
   }
   // Find Suspend Below Min Bitrate constraint.
-  ConstraintToOptionalBool(
-      constraints,
-      MediaConstraintsInterface::kEnableVideoSuspendBelowMinBitrate,
-      &configuration->suspend_below_min_bitrate);
+  FindConstraint(constraints,
+                 MediaConstraintsInterface::kEnableVideoSuspendBelowMinBitrate,
+                 &configuration->media_config.video.suspend_below_min_bitrate,
+                 nullptr);
   ConstraintToOptionalInt(constraints,
                           MediaConstraintsInterface::kScreencastMinBitrate,
                           &configuration->screencast_min_bitrate);
   ConstraintToOptionalBool(constraints,
                            MediaConstraintsInterface::kCombinedAudioVideoBwe,
                            &configuration->combined_audio_video_bwe);
   ConstraintToOptionalBool(constraints,
                            MediaConstraintsInterface::kEnableDtlsSrtp,
                            &configuration->enable_dtls_srtp);
 }
 
 }  // namespace webrtc