webrtc/media/base/videosinkinterface.h - Issue 1818023002: Delete class webrtc::VideoRenderer and its header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/base/videosinkinterface.h

Issue 1818023002: Delete class webrtc::VideoRenderer and its header file. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Address pbos' comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/base/videosinkinterface.h

diff --git a/webrtc/media/base/videosinkinterface.h b/webrtc/media/base/videosinkinterface.h

index bb41bdb281ddbab6e01c4f77e742159dcdc225c1..df7677bdaf6115838d9209e98d32bde91e33b085 100644

--- a/webrtc/media/base/videosinkinterface.h

+++ b/webrtc/media/base/videosinkinterface.h

@@ -11,6 +11,9 @@

#ifndef WEBRTC_MEDIA_BASE_VIDEOSINKINTERFACE_H_

#define WEBRTC_MEDIA_BASE_VIDEOSINKINTERFACE_H_

+// TODO(nisse): Consider moving this interface (and possibly

+// VideoSourceInterface too) from media/base to common_video, to

perkj_webrtc 2016/03/22 08:43:44 Is this really correct? Shouldn't we go the opposi

nisse-webrtc 2016/03/22 10:47:14 What's the opposite path, moving stuff from common

+// reduce dependency cycles.

namespace rtc {

template <typename VideoFrameT>

« no previous file with comments | « webrtc/common_video/incoming_video_stream.cc ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | webrtc/media/engine/webrtcvideoengine2.h » ('J')