Delete class webrtc::VideoRenderer and its header file.

Delete class webrtc::VideoRenderer and its header file.

To replace the SmoothsRenderedFrames method, added a corresponding
flag to VideoReceiveStream::Config instead.

BUG=webrtc:5426
Committed: https://crrev.com/7ade7b3282aa18177768b1615719e67cc4ba87ce
Cr-Commit-Position: refs/heads/master@{#12102}

[nisse-webrtc, 2016-03-21 12:58:42]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org, perkj@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

[nisse-webrtc, 2016-03-21 12:58:42]

This is a followup to https://codereview.webrtc.org/1814763002/, deleting the
class. Also deleting one of the top-level webrtc header files.

I haven't found any external use of this header file or class, but I could have
missed something, of course.

[nisse-webrtc, 2016-03-21 12:59:40]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 12:59:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818023002/1

[commit-bot: I haz the power, 2016-03-21 15:00:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 15:00:19]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[pbos-webrtc, 2016-03-21 16:53:35]

pbos@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[pbos-webrtc, 2016-03-21 16:53:36]

+kjellander because I think this adds cycles to our DEPS graph.

https://codereview.webrtc.org/1818023002/diff/1/webrtc/DEPS
File webrtc/DEPS (right):

https://codereview.webrtc.org/1818023002/diff/1/webrtc/DEPS#newcode48
webrtc/DEPS:48: "+webrtc/media/base",
Can you make a TODO that considers moving video_sink_interface into
webrtc/common_video? I don't think we've had cycles from webrtc/video into
webrtc/media before.

https://codereview.webrtc.org/1818023002/diff/1/webrtc/test/video_renderer.h
File webrtc/test/video_renderer.h (right):

https://codereview.webrtc.org/1818023002/diff/1/webrtc/test/video_renderer.h#...
webrtc/test/video_renderer.h:15: #include
"webrtc/media/base/videosinkinterface.h"
Consider moving this interface to webrtc/common_video/ I think this creates
cycles in our build graph that we're trying to get rid of.

https://codereview.webrtc.org/1818023002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1818023002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:169: config.renderer ?
config.disable_prerenderer_smoothing : false),
I think you can remove this conditional now

[kjellander_webrtc, 2016-03-21 21:31:51]

lgtm since I don't see this making things any worse. It's rather great to see
one header in webrtc/ go away.
Moving headers to reduce circular dependencies should be done in separate CLs
anyway.

[nisse-webrtc, 2016-03-22 07:45:31]

https://codereview.webrtc.org/1818023002/diff/1/webrtc/DEPS
File webrtc/DEPS (right):

https://codereview.webrtc.org/1818023002/diff/1/webrtc/DEPS#newcode48
webrtc/DEPS:48: "+webrtc/media/base",
On 2016/03/21 16:53:35, pbos-webrtc wrote:
> Can you make a TODO that considers moving video_sink_interface into
> webrtc/common_video? I don't think we've had cycles from webrtc/video into
> webrtc/media before.

Added a TODO in videosinkinterface.h.

https://codereview.webrtc.org/1818023002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1818023002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:169: config.renderer ?
config.disable_prerenderer_smoothing : false),
On 2016/03/21 16:53:35, pbos-webrtc wrote:
> I think you can remove this conditional now

Done.

[perkj_webrtc, 2016-03-22 08:43:44]

lgtm with nits

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
File webrtc/media/base/videosinkinterface.h (right):

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
webrtc/media/base/videosinkinterface.h:15: // VideoSourceInterface too) from
media/base to common_video, to
Is this really correct? Shouldn't we go the opposite path?  I think you should
just remove this TODO.

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.h (right):

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.h:397: // cricket::VideoRenderer.
Not true. cricket::VIdeoRenderer is no more.

[perkj_webrtc, 2016-03-22 08:43:59]

On 2016/03/22 08:43:44, perkj_webrtc wrote:
> lgtm with nits
> 
>
https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
> File webrtc/media/base/videosinkinterface.h (right):
> 
>
https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
> webrtc/media/base/videosinkinterface.h:15: // VideoSourceInterface too) from
> media/base to common_video, to
> Is this really correct? Shouldn't we go the opposite path?  I think you should
> just remove this TODO.
> 
>
https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
> File webrtc/media/engine/webrtcvideoengine2.h (right):
> 
>
https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
> webrtc/media/engine/webrtcvideoengine2.h:397: // cricket::VideoRenderer.
> Not true. cricket::VIdeoRenderer is no more.

Nice by the way!

[nisse-webrtc, 2016-03-22 10:47:14]

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
File webrtc/media/base/videosinkinterface.h (right):

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/base/videosi...
webrtc/media/base/videosinkinterface.h:15: // VideoSourceInterface too) from
media/base to common_video, to
On 2016/03/22 08:43:44, perkj_webrtc wrote:
> Is this really correct? Shouldn't we go the opposite path?  I think you should
> just remove this TODO.

What's the opposite path, moving stuff from common_video to media/base? It
appears that when we start using VideoSinkInterface, further down in the video
code, this adds another cyclic dependency between directories. So pbos suggested
I added a TODO about moving things around. Myself, I don't have any strong
opinion on this.

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.h (right):

https://codereview.webrtc.org/1818023002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.h:397: // cricket::VideoRenderer.
On 2016/03/22 08:43:44, perkj_webrtc wrote:
> Not true. cricket::VIdeoRenderer is no more.

I'm updating the comment. cricket::VideoRenderer is not involved here (but it
still exists elsewhere... Haven't yet tried to delete it). In this case, its
VideoSinkInterface<webrtc::VideoFrame> vs
VideoSinkInterface<cricket::VideoFrame>.

[pbos-webrtc, 2016-03-22 19:13:54]

lgtm

[pthatcher1, 2016-03-22 21:17:15]

lgtm

[tommi, 2016-03-23 09:10:25]

rs lgtm. ship it!

[tommi, 2016-03-23 09:10:30]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-03-23 09:10:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1818023002/#ps40001 (title:
"Comment fix.")

[commit-bot: I haz the power, 2016-03-23 09:10:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818023002/40001

[commit-bot: I haz the power, 2016-03-23 09:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 09:11:50]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  ios32_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/6188)
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/6176)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/8514)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/8431)
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/13715)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/12346)
  linux_ubsan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/746)
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/13368)
  mac_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/1829)
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8058)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/13756)

[nisse-webrtc, 2016-03-23 09:42:18]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-23 09:42:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
kjellander@webrtc.org, pbos@webrtc.org, pthatcher@webrtc.org, perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1818023002/#ps60001 (title:
"Rebased.")

[commit-bot: I haz the power, 2016-03-23 09:42:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1818023002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1818023002/60001

[commit-bot: I haz the power, 2016-03-23 11:48:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-23 11:48:21]

Description was changed from

==========
Delete class webrtc::VideoRenderer and its header file.

To replace the SmoothsRenderedFrames method, added a corresponding
flag to VideoReceiveStream::Config instead.

BUG=webrtc:5426
==========

to

==========
Delete class webrtc::VideoRenderer and its header file.

To replace the SmoothsRenderedFrames method, added a corresponding
flag to VideoReceiveStream::Config instead.

BUG=webrtc:5426

Committed: https://crrev.com/7ade7b3282aa18177768b1615719e67cc4ba87ce
Cr-Commit-Position: refs/heads/master@{#12102}
==========

[commit-bot: I haz the power, 2016-03-23 11:48:22]

Patchset 4 (id:??) landed as
https://crrev.com/7ade7b3282aa18177768b1615719e67cc4ba87ce
Cr-Commit-Position: refs/heads/master@{#12102}