Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1815733002: Fixing crash that may occur after destroying a VideoSendStream. (Closed)

Created:
4 years, 9 months ago by Taylor Brandstetter
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing crash that may occur after destroying a VideoSendStream. It was possible that even after a VideoSendStream was destroyed, it remained registered as a BitrateAllocator observer, causing a segfault later. Committed: https://crrev.com/62411a21c9461265cc0fa69e947afafc00f8c807 Cr-Commit-Position: refs/heads/master@{#12067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/video/video_send_stream.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
Taylor Brandstetter
PTAL.
4 years, 9 months ago (2016-03-18 18:36:11 UTC) #2
pbos-webrtc
lgtm
4 years, 9 months ago (2016-03-18 23:12:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815733002/1
4 years, 9 months ago (2016-03-18 23:31:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 9 months ago (2016-03-19 01:32:18 UTC) #8
mflodman
LGTM, thanks Taylor!
4 years, 9 months ago (2016-03-20 07:13:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815733002/1
4 years, 9 months ago (2016-03-20 13:35:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11898)
4 years, 9 months ago (2016-03-20 14:49:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815733002/1
4 years, 9 months ago (2016-03-20 20:22:41 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-20 21:24:53 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-20 21:25:04 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62411a21c9461265cc0fa69e947afafc00f8c807
Cr-Commit-Position: refs/heads/master@{#12067}

Powered by Google App Engine
This is Rietveld 408576698