Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Side by Side Diff: webrtc/api/webrtcsdp_unittest.cc

Issue 1815473002: Add 16-bit network id to the candidate signaling. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Remove the old NETWORK_COST attribute. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/webrtcsdp.cc ('k') | webrtc/base/network.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 2040 matching lines...) Expand 10 before | Expand all | Expand 10 after
2051 TEST_F(WebRtcSdpTest, SerializeCandidates) { 2051 TEST_F(WebRtcSdpTest, SerializeCandidates) {
2052 std::string message = webrtc::SdpSerializeCandidate(*jcandidate_); 2052 std::string message = webrtc::SdpSerializeCandidate(*jcandidate_);
2053 EXPECT_EQ(std::string(kRawCandidate), message); 2053 EXPECT_EQ(std::string(kRawCandidate), message);
2054 2054
2055 Candidate candidate_with_ufrag(candidates_.front()); 2055 Candidate candidate_with_ufrag(candidates_.front());
2056 candidate_with_ufrag.set_username("ABC"); 2056 candidate_with_ufrag.set_username("ABC");
2057 jcandidate_.reset(new JsepIceCandidate(std::string("audio_content_name"), 0, 2057 jcandidate_.reset(new JsepIceCandidate(std::string("audio_content_name"), 0,
2058 candidate_with_ufrag)); 2058 candidate_with_ufrag));
2059 message = webrtc::SdpSerializeCandidate(*jcandidate_); 2059 message = webrtc::SdpSerializeCandidate(*jcandidate_);
2060 EXPECT_EQ(std::string(kRawCandidate) + " ufrag ABC", message); 2060 EXPECT_EQ(std::string(kRawCandidate) + " ufrag ABC", message);
2061
2062 Candidate candidate_with_network_info(candidates_.front());
2063 candidate_with_network_info.set_network_id(1);
2064 jcandidate_.reset(new JsepIceCandidate(std::string("audio"), 0,
2065 candidate_with_network_info));
2066 message = webrtc::SdpSerializeCandidate(*jcandidate_);
2067 EXPECT_EQ(std::string(kRawCandidate) + " network-id 1", message);
2068 candidate_with_network_info.set_network_cost(999);
2069 jcandidate_.reset(new JsepIceCandidate(std::string("audio"), 0,
2070 candidate_with_network_info));
2071 message = webrtc::SdpSerializeCandidate(*jcandidate_);
2072 EXPECT_EQ(std::string(kRawCandidate) + " network-id 1 network-cost 999",
2073 message);
2061 } 2074 }
2062 2075
2063 // TODO(mallinath) : Enable this test once WebRTCSdp capable of parsing 2076 // TODO(mallinath) : Enable this test once WebRTCSdp capable of parsing
2064 // RFC 6544. 2077 // RFC 6544.
2065 TEST_F(WebRtcSdpTest, SerializeTcpCandidates) { 2078 TEST_F(WebRtcSdpTest, SerializeTcpCandidates) {
2066 Candidate candidate(ICE_CANDIDATE_COMPONENT_RTP, "tcp", 2079 Candidate candidate(ICE_CANDIDATE_COMPONENT_RTP, "tcp",
2067 rtc::SocketAddress("192.168.1.5", 9), kCandidatePriority, 2080 rtc::SocketAddress("192.168.1.5", 9), kCandidatePriority,
2068 "", "", LOCAL_PORT_TYPE, kCandidateGeneration, 2081 "", "", LOCAL_PORT_TYPE, kCandidateGeneration,
2069 kCandidateFoundation1); 2082 kCandidateFoundation1);
2070 candidate.set_tcptype(cricket::TCPTYPE_ACTIVE_STR); 2083 candidate.set_tcptype(cricket::TCPTYPE_ACTIVE_STR);
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
2318 } 2331 }
2319 2332
2320 TEST_F(WebRtcSdpTest, DeserializeCandidate) { 2333 TEST_F(WebRtcSdpTest, DeserializeCandidate) {
2321 JsepIceCandidate jcandidate(kDummyMid, kDummyIndex); 2334 JsepIceCandidate jcandidate(kDummyMid, kDummyIndex);
2322 2335
2323 std::string sdp = kSdpOneCandidate; 2336 std::string sdp = kSdpOneCandidate;
2324 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate)); 2337 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate));
2325 EXPECT_EQ(kDummyMid, jcandidate.sdp_mid()); 2338 EXPECT_EQ(kDummyMid, jcandidate.sdp_mid());
2326 EXPECT_EQ(kDummyIndex, jcandidate.sdp_mline_index()); 2339 EXPECT_EQ(kDummyIndex, jcandidate.sdp_mline_index());
2327 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(jcandidate_->candidate())); 2340 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(jcandidate_->candidate()));
2341 EXPECT_EQ(0, jcandidate.candidate().network_cost());
2328 2342
2329 // Candidate line without generation extension. 2343 // Candidate line without generation extension.
2330 sdp = kSdpOneCandidate; 2344 sdp = kSdpOneCandidate;
2331 Replace(" generation 2", "", &sdp); 2345 Replace(" generation 2", "", &sdp);
2332 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate)); 2346 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate));
2333 EXPECT_EQ(kDummyMid, jcandidate.sdp_mid()); 2347 EXPECT_EQ(kDummyMid, jcandidate.sdp_mid());
2334 EXPECT_EQ(kDummyIndex, jcandidate.sdp_mline_index()); 2348 EXPECT_EQ(kDummyIndex, jcandidate.sdp_mline_index());
2335 Candidate expected = jcandidate_->candidate(); 2349 Candidate expected = jcandidate_->candidate();
2336 expected.set_generation(0); 2350 expected.set_generation(0);
2337 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(expected)); 2351 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(expected));
2338 2352
2353 // Candidate with network id and/or cost.
2354 sdp = kSdpOneCandidate;
2355 Replace(" generation 2", " generation 2 network-id 2", &sdp);
2356 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate));
2357 EXPECT_EQ(kDummyMid, jcandidate.sdp_mid());
2358 EXPECT_EQ(kDummyIndex, jcandidate.sdp_mline_index());
2359 expected = jcandidate_->candidate();
2360 expected.set_network_id(2);
2361 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(expected));
2362 EXPECT_EQ(0, jcandidate.candidate().network_cost());
2363 // Add network cost
2364 Replace(" network-id 2", " network-id 2 network-cost 9", &sdp);
2365 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate));
2366 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(expected));
2367 EXPECT_EQ(9, jcandidate.candidate().network_cost());
2368
2339 sdp = kSdpTcpActiveCandidate; 2369 sdp = kSdpTcpActiveCandidate;
2340 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate)); 2370 EXPECT_TRUE(SdpDeserializeCandidate(sdp, &jcandidate));
2341 // Make a cricket::Candidate equivalent to kSdpTcpCandidate string. 2371 // Make a cricket::Candidate equivalent to kSdpTcpCandidate string.
2342 Candidate candidate(ICE_CANDIDATE_COMPONENT_RTP, "tcp", 2372 Candidate candidate(ICE_CANDIDATE_COMPONENT_RTP, "tcp",
2343 rtc::SocketAddress("192.168.1.5", 9), kCandidatePriority, 2373 rtc::SocketAddress("192.168.1.5", 9), kCandidatePriority,
2344 "", "", LOCAL_PORT_TYPE, kCandidateGeneration, 2374 "", "", LOCAL_PORT_TYPE, kCandidateGeneration,
2345 kCandidateFoundation1); 2375 kCandidateFoundation1);
2346 rtc::scoped_ptr<IceCandidateInterface> jcandidate_template( 2376 rtc::scoped_ptr<IceCandidateInterface> jcandidate_template(
2347 new JsepIceCandidate(std::string("audio_content_name"), 0, candidate)); 2377 new JsepIceCandidate(std::string("audio_content_name"), 0, candidate));
2348 EXPECT_TRUE(jcandidate.candidate().IsEquivalent( 2378 EXPECT_TRUE(jcandidate.candidate().IsEquivalent(
(...skipping 733 matching lines...) Expand 10 before | Expand all | Expand 10 after
3082 EXPECT_TRUE( 3112 EXPECT_TRUE(
3083 SdpDeserialize(kUnifiedPlanSdpFullString, &deserialized_description)); 3113 SdpDeserialize(kUnifiedPlanSdpFullString, &deserialized_description));
3084 3114
3085 EXPECT_TRUE(CompareSessionDescription(jdesc_, deserialized_description)); 3115 EXPECT_TRUE(CompareSessionDescription(jdesc_, deserialized_description));
3086 } 3116 }
3087 3117
3088 TEST_F(WebRtcSdpTest, SerializeUnifiedPlanSessionDescription) { 3118 TEST_F(WebRtcSdpTest, SerializeUnifiedPlanSessionDescription) {
3089 MakeUnifiedPlanDescription(); 3119 MakeUnifiedPlanDescription();
3090 TestSerialize(jdesc_, true); 3120 TestSerialize(jdesc_, true);
3091 } 3121 }
OLDNEW
« no previous file with comments | « webrtc/api/webrtcsdp.cc ('k') | webrtc/base/network.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698