Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1814703005: Remove webrtc/sounds/DEPS. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/sound/DEPS. BUG=webrtc:5579 NOTRY=True Committed: https://crrev.com/3b4d07445268764f5e59bf29af62bff6d3c20b04 Cr-Commit-Position: refs/heads/master@{#12051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
D webrtc/sound/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
the sun
4 years, 9 months ago (2016-03-18 09:21:32 UTC) #2
kjellander_webrtc
lgtm I added NOTRY=True
4 years, 9 months ago (2016-03-18 10:37:10 UTC) #4
kjellander_webrtc
nit: s/sounds/sound in title+CL desc.
4 years, 9 months ago (2016-03-18 10:37:32 UTC) #5
the sun
On 2016/03/18 10:37:32, kjellander (webrtc) wrote: > nit: s/sounds/sound in title+CL desc. Done + thanks!
4 years, 9 months ago (2016-03-18 10:45:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814703005/1
4 years, 9 months ago (2016-03-18 10:46:04 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4247)
4 years, 9 months ago (2016-03-18 11:35:55 UTC) #11
the sun
tommi@, webrtc/ OWNERS
4 years, 9 months ago (2016-03-18 12:11:40 UTC) #13
tommi
lgtm
4 years, 9 months ago (2016-03-18 13:23:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814703005/1
4 years, 9 months ago (2016-03-18 13:23:46 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 13:25:28 UTC) #18
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 13:25:31 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b4d07445268764f5e59bf29af62bff6d3c20b04
Cr-Commit-Position: refs/heads/master@{#12051}

Powered by Google App Engine
This is Rietveld 408576698